Skip to content

[Bugfix] Bugfix for getting maximum matching length of conditional mark. #14515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yejianquan merged 2 commits into from
Sep 12, 2024
Merged

[Bugfix] Bugfix for getting maximum matching length of conditional mark. #14515

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c1b7f61
Bugfix
yutongzhang-microsoft Sep 11, 2024
d8b8c8f
Fix
yutongzhang-microsoft Sep 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion tests/common/plugins/conditional_mark/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -428,7 +428,7 @@ def find_all_matches(nodeid, conditions):
marks = match[case_starting_substring].keys()
for mark in marks:
if mark in conditional_marks:
if length > max_length:
if length >= max_length:
conditional_marks.update({
mark: {
case_starting_substring: {
Expand All @@ -441,6 +441,7 @@ def find_all_matches(nodeid, conditions):
case_starting_substring: {
mark: match[case_starting_substring][mark]}
}})
max_length = length

# We may have the same matches of different marks
# Need to remove duplicate here
Expand Down