Skip to content

[Bugfix] Bugfix for getting maximum matching length of conditional mark. #14515

Merged
yejianquan merged 2 commits intosonic-net:masterfrom
yutongzhang-microsoft:yutongzhang/bugfix_conditional_mark
Sep 12, 2024
Merged

[Bugfix] Bugfix for getting maximum matching length of conditional mark. #14515
yejianquan merged 2 commits intosonic-net:masterfrom
yutongzhang-microsoft:yutongzhang/bugfix_conditional_mark

Conversation

@yutongzhang-microsoft
Copy link
Contributor

@yutongzhang-microsoft yutongzhang-microsoft commented Sep 11, 2024

Description of PR

We changed the matching rule of conditional mark in PR #14395. There is a bug when getting the maximum matching length. In this PR, we fix this bug.

Summary:
Fixes # (issue)

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 202012
  • 202205
  • 202305
  • 202311
  • 202405

Approach

What is the motivation for this PR?

We changed the matching rule of conditional mark in PR #14395. There is a bug when getting the maximum matching length. In this PR, we fix this bug.

How did you do it?

How did you verify/test it?

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

Copy link
Collaborator

@yejianquan yejianquan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yejianquan yejianquan merged commit dbfbda0 into sonic-net:master Sep 12, 2024
@yutongzhang-microsoft yutongzhang-microsoft deleted the yutongzhang/bugfix_conditional_mark branch September 12, 2024 06:49
hdwhdw pushed a commit to hdwhdw/sonic-mgmt that referenced this pull request Sep 20, 2024
…rk. (sonic-net#14515)

Description of PR
We changed the matching rule of conditional mark in PR sonic-net#14395. There is a bug when getting the maximum matching length. In this PR, we fix this bug.

Approach
What is the motivation for this PR?
We changed the matching rule of conditional mark in PR sonic-net#14395. There is a bug when getting the maximum matching length. In this PR, we fix this bug.

co-authorized by: jianquanye@microsoft.com
arista-hpandya pushed a commit to arista-hpandya/sonic-mgmt that referenced this pull request Oct 2, 2024
…rk. (sonic-net#14515)

Description of PR
We changed the matching rule of conditional mark in PR sonic-net#14395. There is a bug when getting the maximum matching length. In this PR, we fix this bug.

Approach
What is the motivation for this PR?
We changed the matching rule of conditional mark in PR sonic-net#14395. There is a bug when getting the maximum matching length. In this PR, we fix this bug.

co-authorized by: jianquanye@microsoft.com
@mssonicbld
Copy link
Collaborator

@yutongzhang-microsoft PR conflicts with 202405 branch

yutongzhang-microsoft added a commit to yutongzhang-microsoft/sonic-mgmt that referenced this pull request Oct 18, 2024
wangxin pushed a commit that referenced this pull request Oct 23, 2024
vikshaw-Nokia pushed a commit to vikshaw-Nokia/sonic-mgmt that referenced this pull request Oct 23, 2024
…rk. (sonic-net#14515)

Description of PR
We changed the matching rule of conditional mark in PR sonic-net#14395. There is a bug when getting the maximum matching length. In this PR, we fix this bug.

Approach
What is the motivation for this PR?
We changed the matching rule of conditional mark in PR sonic-net#14395. There is a bug when getting the maximum matching length. In this PR, we fix this bug.

co-authorized by: jianquanye@microsoft.com
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants