Move all paltform test conditional marks to tests_mark_conditions_platform_tests.yaml. #14370
Merged
wangxin merged 1 commit intosonic-net:masterfrom Sep 5, 2024
Conversation
Contributor
|
Is it possible to add some PR check to avoid people add platform testcases in |
Contributor
Author
Good suggestion! Maybe we can add some checks in Pre_test Static Analysis. |
xwjiang-ms
approved these changes
Sep 3, 2024
opcoder0
approved these changes
Sep 3, 2024
Contributor
opcoder0
left a comment
opcoder0
left a comment
There was a problem hiding this comment.
LGTM. Just a minor comment on the closed issue.
| platform_tests/test_auto_negotiation.py: | ||
| skip: | ||
| reason: "auto negotiation test highly depends on test enviroments, file issue to track and skip for now" | ||
| conditions: https://github.com/sonic-net/sonic-mgmt/issues/5447 |
Contributor
There was a problem hiding this comment.
This issue is closed. Will this still be skipped?
Contributor
There was a problem hiding this comment.
If issue is closed, then testcase will not be skipped.
lizhijianrd
approved these changes
Sep 3, 2024
wangxin
approved these changes
Sep 5, 2024
hdwhdw
pushed a commit
to hdwhdw/sonic-mgmt
that referenced
this pull request
Sep 20, 2024
…yaml` (sonic-net#14370) What is the motivation for this PR? We have a specific yaml file tests/common/plugins/conditional_mark/tests_mark_conditions_platform_tests.yaml to record the conditional marks of platfrom test. In this PR, we move all the conditional marks of platform test in tests_mark_conditions.yaml to its specific yaml file. And if the key of conditional mark is repetitive in these two files, we combine them together. How did you do it? Move all paltform test conditional marks to tests_mark_conditions_platform_tests.yaml and combine the repetitive keys.
arista-hpandya
pushed a commit
to arista-hpandya/sonic-mgmt
that referenced
this pull request
Oct 2, 2024
…yaml` (sonic-net#14370) What is the motivation for this PR? We have a specific yaml file tests/common/plugins/conditional_mark/tests_mark_conditions_platform_tests.yaml to record the conditional marks of platfrom test. In this PR, we move all the conditional marks of platform test in tests_mark_conditions.yaml to its specific yaml file. And if the key of conditional mark is repetitive in these two files, we combine them together. How did you do it? Move all paltform test conditional marks to tests_mark_conditions_platform_tests.yaml and combine the repetitive keys.
Collaborator
|
@yutongzhang-microsoft PR conflicts with 202205 branch |
Collaborator
|
@yutongzhang-microsoft PR conflicts with 202311 branch |
Collaborator
|
@yutongzhang-microsoft PR conflicts with 202012 branch |
Collaborator
|
@yutongzhang-microsoft PR conflicts with 202405 branch |
Collaborator
|
@yutongzhang-microsoft PR conflicts with 202305 branch |
yutongzhang-microsoft
added
Included in 202405 branch
and removed
Cherry Pick Conflict_202405
labels
8 tasks
yutongzhang-microsoft
added
Included in 202311 branch
and removed
Cherry Pick Conflict_202311
labels
8 tasks
yutongzhang-microsoft
added a commit
to yutongzhang-microsoft/sonic-mgmt
that referenced
this pull request
Oct 11, 2024
8 tasks
yutongzhang-microsoft
added a commit
to yutongzhang-microsoft/sonic-mgmt
that referenced
this pull request
Oct 11, 2024
8 tasks
yutongzhang-microsoft
added
Included in 202305 branch
and removed
Cherry Pick Conflict_202305
labels
vikshaw-Nokia
pushed a commit
to vikshaw-Nokia/sonic-mgmt
that referenced
this pull request
Oct 23, 2024
…yaml` (sonic-net#14370) What is the motivation for this PR? We have a specific yaml file tests/common/plugins/conditional_mark/tests_mark_conditions_platform_tests.yaml to record the conditional marks of platfrom test. In this PR, we move all the conditional marks of platform test in tests_mark_conditions.yaml to its specific yaml file. And if the key of conditional mark is repetitive in these two files, we combine them together. How did you do it? Move all paltform test conditional marks to tests_mark_conditions_platform_tests.yaml and combine the repetitive keys.
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
…et#17179) * Revert "[202205] [Mellanox] Fix issue: user must set admin down before toggling LPM (sonic-net#14370)" This reverts commit f74c69e. * update copyright header Signed-off-by: Kebo Liu <kebol@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
We have a specific yaml file
tests/common/plugins/conditional_mark/tests_mark_conditions_platform_tests.yamlto record the conditional marks of platfrom test. In this PR, we move all the conditional marks of platform test intests_mark_conditions.yamlto its specific yaml file. And if the key of conditional mark is duplicate in these two files, we combine them together.Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
We have a specific yaml file
tests/common/plugins/conditional_mark/tests_mark_conditions_platform_tests.yamlto record the conditional marks of platfrom test. In this PR, we move all the conditional marks of platform test intests_mark_conditions.yamlto its specific yaml file. And if the key of conditional mark is repetitive in these two files, we combine them together.How did you do it?
Move all paltform test conditional marks to
tests_mark_conditions_platform_tests.yamland combine the repetitive keys.How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation