Merged
Conversation
Collaborator
|
/azp run |
12 tasks
tests/bmp/test_docker_restart.py
Outdated
|
|
||
|
|
||
| def test_restart_bmp_docker(duthosts, | ||
| def test_restart_bmp_docker(duthosts, enable_bmp_feature, |
Contributor
There was a problem hiding this comment.
Thanks @vivekverma-arista for making this fix, I've leave one comment on sonic-net/sonic-buildimage#21863 for further discussing.
Contributor
There was a problem hiding this comment.
@vivekverma-arista could you help to fix the flake8 failure?
Collaborator
|
/azp run Azure.sonic-mgmt |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
hi @vivekverma-arista could you check the static failure? |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
Done |
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Mar 6, 2025
What is the motivation for this PR? bmp/test_bmp_statedb.py and bmp/test_docker_restart.py are failing as they try to test BMP without enabling it. How did you do it? Created a fixture to enable BMP. For the CLI to work we also need: sonic-net/sonic-buildimage#21863 How did you verify/test it? Ran all tests in the BMP directory.
Collaborator
|
Cherry-pick PR to 202411: #17397 |
11 tasks
mssonicbld
pushed a commit
that referenced
this pull request
Mar 11, 2025
What is the motivation for this PR? bmp/test_bmp_statedb.py and bmp/test_docker_restart.py are failing as they try to test BMP without enabling it. How did you do it? Created a fixture to enable BMP. For the CLI to work we also need: sonic-net/sonic-buildimage#21863 How did you verify/test it? Ran all tests in the BMP directory.
mssonicbld
added
Included in 202411 branch
and removed
Created PR to 202411 branch
labels
nnelluri-cisco
pushed a commit
to nnelluri-cisco/sonic-mgmt
that referenced
this pull request
Mar 15, 2025
What is the motivation for this PR? bmp/test_bmp_statedb.py and bmp/test_docker_restart.py are failing as they try to test BMP without enabling it. How did you do it? Created a fixture to enable BMP. For the CLI to work we also need: sonic-net/sonic-buildimage#21863 How did you verify/test it? Ran all tests in the BMP directory.
vivekverma-arista
added a commit
to vivekverma-arista/sonic-mgmt
that referenced
this pull request
Mar 19, 2025
This reverts commit d9aa087.
StormLiangMS
pushed a commit
that referenced
this pull request
Mar 20, 2025
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Mar 20, 2025
This reverts commit d9aa087.
mssonicbld
pushed a commit
that referenced
this pull request
Mar 20, 2025
amulyan7
pushed a commit
to amulyan7/sonic-mgmt
that referenced
this pull request
Mar 31, 2025
This reverts commit d9aa087.
OriTrabelsi
pushed a commit
to OriTrabelsi/sonic-mgmt
that referenced
this pull request
Apr 1, 2025
What is the motivation for this PR? bmp/test_bmp_statedb.py and bmp/test_docker_restart.py are failing as they try to test BMP without enabling it. How did you do it? Created a fixture to enable BMP. For the CLI to work we also need: sonic-net/sonic-buildimage#21863 How did you verify/test it? Ran all tests in the BMP directory.
OriTrabelsi
pushed a commit
to OriTrabelsi/sonic-mgmt
that referenced
this pull request
Apr 1, 2025
This reverts commit d9aa087.
opcoder0
pushed a commit
to opcoder0/sonic-mgmt
that referenced
this pull request
Dec 8, 2025
This reverts commit d9aa087. Signed-off-by: opcoder0 <[email protected]>
gshemesh2
pushed a commit
to gshemesh2/sonic-mgmt
that referenced
this pull request
Dec 21, 2025
This reverts commit d9aa087. Signed-off-by: Guy Shemesh <[email protected]>
gshemesh2
pushed a commit
to gshemesh2/sonic-mgmt
that referenced
this pull request
Jan 26, 2026
This reverts commit d9aa087. Signed-off-by: Guy Shemesh <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary: Fix BMP tests
Fixes #459
Type of change
Back port request
Approach
What is the motivation for this PR?
bmp/test_bmp_statedb.pyandbmp/test_docker_restart.pyare failing as they try to test BMP without enabling it.How did you do it?
Created a fixture to enable BMP. For the CLI to work we also need: sonic-net/sonic-buildimage#21863
How did you verify/test it?
Ran all tests in the BMP directory.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation