Skip to content

Enable Py3 and fix issue for lag test#14031

Merged
wangxin merged 1 commit intosonic-net:masterfrom
opcoder0:fix/acs-lag-test
Aug 8, 2024
Merged

Enable Py3 and fix issue for lag test#14031
wangxin merged 1 commit intosonic-net:masterfrom
opcoder0:fix/acs-lag-test

Conversation

@opcoder0
Copy link
Contributor

@opcoder0 opcoder0 commented Aug 8, 2024

Description of PR

Bug fix for PR - #14001

  • Fix to enable python3 for pc/test_lag_2.py -> acstest/lag_test.py.
  • Fix error that fails in py3 environment

Summary:
Fixes # Not applicable

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 202012
  • 202205
  • 202305
  • 202311
  • 202405

Approach

What is the motivation for this PR?

Fix bug in PR #14001

How did you do it?

Enable the test to run in python 3 environment, and fix an issue in lag_test.py

How did you verify/test it?

Run test on vs testbed.

Any platform specific information?

Not applicable to the change.

Supported testbed topology if it's a new test case?

Not applicable

Documentation

Not applicable

@wangxin wangxin changed the title Enable Py3 and fix issue Enable Py3 and fix issue for lag test Aug 8, 2024
@wangxin wangxin merged commit f06d2a9 into sonic-net:master Aug 8, 2024
arista-hpandya pushed a commit to arista-hpandya/sonic-mgmt that referenced this pull request Oct 2, 2024
saiarcot895 added a commit to saiarcot895/sonic-mgmt that referenced this pull request Oct 10, 2024
PR sonic-net#14001 moved the lag_test PTF script into the Python 3 folder, but
PR sonic-net#14031 missed updating this test. Update this test to reflect that
the lag_test script should be run under Python 3.

Signed-off-by: Saikrishna Arcot <[email protected]>
@saiarcot895 saiarcot895 mentioned this pull request Oct 10, 2024
8 tasks
vikshaw-Nokia pushed a commit to vikshaw-Nokia/sonic-mgmt that referenced this pull request Oct 23, 2024
@vrajeshe
Copy link
Contributor

@wangxin
current_pkt_timing = intervals[int(self.interval_count / 2)]
this fix should be present in 202405 release and other releases too can it be ported?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants