[acstests] Migrate lag test to Python 3#14001
Merged
wangxin merged 2 commits intosonic-net:masterfrom Aug 7, 2024
Merged
Conversation
xwjiang-ms
approved these changes
Aug 6, 2024
yutongzhang-microsoft
approved these changes
Aug 7, 2024
8 tasks
wangxin
approved these changes
Aug 7, 2024
8 tasks
arista-hpandya
pushed a commit
to arista-hpandya/sonic-mgmt
that referenced
this pull request
Oct 2, 2024
What is the motivation for this PR? As Python 2 is EOL-ed all the PTF test scripts will need to be migrated to Python 3. This PR migrates acstest lag_test to Python 3. How did you do it? Ran 2to3 How did you verify/test it? Ran LAG test on virtual testbed. Tests have passed
saiarcot895
added a commit
to saiarcot895/sonic-mgmt
that referenced
this pull request
Oct 10, 2024
PR sonic-net#14001 moved the lag_test PTF script into the Python 3 folder, but PR sonic-net#14031 missed updating this test. Update this test to reflect that the lag_test script should be run under Python 3. Signed-off-by: Saikrishna Arcot <[email protected]>
8 tasks
vikshaw-Nokia
pushed a commit
to vikshaw-Nokia/sonic-mgmt
that referenced
this pull request
Oct 23, 2024
What is the motivation for this PR? As Python 2 is EOL-ed all the PTF test scripts will need to be migrated to Python 3. This PR migrates acstest lag_test to Python 3. How did you do it? Ran 2to3 How did you verify/test it? Ran LAG test on virtual testbed. Tests have passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
In an effort to move all PTF tests to Python 3. This PR moves
acstest/lag_test.pyto Python 3 as it is a PTF test.Summary:
Fixes # Not applicable
Type of change
Back port request
Approach
What is the motivation for this PR?
As Python 2 is EOL-ed all the PTF test scripts will need to be migrated to Python 3. This PR migrates acstest lag_test to Python 3.
How did you do it?
Ran
2to3How did you verify/test it?
Ran LAG test on virtual testbed. Tests have passed
Any platform specific information?
Not applicable
Supported testbed topology if it's a new test case?
Not applicable
Documentation
Not applicable