[202405]Fix test_cacl_application for latest change in caclmgrd#13900
Merged
wangxin merged 2 commits intosonic-net:202405from Aug 2, 2024
Merged
[202405]Fix test_cacl_application for latest change in caclmgrd#13900wangxin merged 2 commits intosonic-net:202405from
wangxin merged 2 commits intosonic-net:202405from
Conversation
) What is the motivation for this PR? RP test will fail after sonic-net/sonic-host-services#139, update the case accordingly. How did you do it? add expected iptable rules How did you verify/test it? run cacl/test_cacl_application.py Signed-off-by: Zhaohui Sun <zhaohuisun@microsoft.com>
Signed-off-by: Zhaohui Sun <zhaohuisun@microsoft.com>
ZhaohuiS
changed the title
wangxin
approved these changes
Aug 1, 2024
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
According PR sonic-net/sonic-host-services#139, the expected iptables rules are changed.
Type of change
Back port request
Approach
What is the motivation for this PR?
Fix PR test failure in sonic-net/sonic-buildimage#19732
How did you do it?
modify expected iptable rules in test_cacl_application case due to image change.
skip cacl/test_cacl_application.py for 202405 branch temporarily
How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation