Fix test_cacl_application for latest change in caclmgrd#13786
Merged
wangxin merged 3 commits intosonic-net:masterfrom Jul 29, 2024
Merged
Fix test_cacl_application for latest change in caclmgrd#13786wangxin merged 3 commits intosonic-net:masterfrom
wangxin merged 3 commits intosonic-net:masterfrom
Conversation
Signed-off-by: Zhaohui Sun <[email protected]>
maipbui
approved these changes
Jul 24, 2024
Signed-off-by: Zhaohui Sun <[email protected]>
Contributor
Author
|
/azp run |
|
Commenter does not have sufficient privileges for PR 13786 in repo sonic-net/sonic-mgmt |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: Zhaohui Sun <[email protected]>
wangxin
reviewed
Jul 29, 2024
| - bgp/test_bgp_speaker.py | ||
| - bgp/test_bgp_update_timer.py | ||
| - bgp/test_bgpmon.py | ||
| - cacl/test_cacl_application.py |
Collaborator
There was a problem hiding this comment.
With the skip rule in conditional mark, probably we can keep this line here to include in in PR testing. Then after the issue is fixed and resolved, then this script will be automatically covered by PR testing.
Contributor
Author
There was a problem hiding this comment.
@wangxin In my second commit, I added the skip condition and kept this line, but PR test still kept failing with this case, that's why I removed this line, I will add this line back when image change is included.
wangxin
approved these changes
Jul 29, 2024
Contributor
|
@ZhaohuiS Why you remove the script |
ZhaohuiS
added a commit
to ZhaohuiS/sonic-mgmt
that referenced
this pull request
Jul 31, 2024
) What is the motivation for this PR? RP test will fail after sonic-net/sonic-host-services#139, update the case accordingly. How did you do it? add expected iptable rules How did you verify/test it? run cacl/test_cacl_application.py Signed-off-by: Zhaohui Sun <[email protected]>
Contributor
|
Hi @ZhaohuiS May I ask is there any plan to cherry-pick to 202405 branch? |
Contributor
Author
@weiguo-nvidia It has been in 202405 already. #13900 |
arista-hpandya
pushed a commit
to arista-hpandya/sonic-mgmt
that referenced
this pull request
Oct 2, 2024
) What is the motivation for this PR? RP test will fail after sonic-net/sonic-host-services#139, update the case accordingly. How did you do it? add expected iptable rules How did you verify/test it? run cacl/test_cacl_application.py Signed-off-by: Zhaohui Sun <[email protected]>
vikshaw-Nokia
pushed a commit
to vikshaw-Nokia/sonic-mgmt
that referenced
this pull request
Oct 23, 2024
) What is the motivation for this PR? RP test will fail after sonic-net/sonic-host-services#139, update the case accordingly. How did you do it? add expected iptable rules How did you verify/test it? run cacl/test_cacl_application.py Signed-off-by: Zhaohui Sun <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
According PR sonic-net/sonic-host-services#139, the expected iptables rules are changed.
Type of change
Back port request
Approach
What is the motivation for this PR?
RP test will fail after sonic-net/sonic-host-services#139, update the case accordingly.
How did you do it?
add expected iptable rules
How did you verify/test it?
run cacl/test_cacl_application.py
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation