[Mellanox] Revert the set_speed function in https://github.com/sonic-net/sonic-mgmt/pull/11763#13649
Merged
bingwang-ms merged 1 commit intosonic-net:masterfrom Jul 22, 2024
Conversation
Change-Id: I753593ed128bd4c6a6915bca8eebf788743d2bd5
JibinBao
changed the title
Contributor
Author
|
/azpw run Azure.sonic-mgmt |
Collaborator
|
/AzurePipelines run Azure.sonic-mgmt |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azpw run Azure.sonic-mgmt |
Collaborator
|
/AzurePipelines run Azure.sonic-mgmt |
|
Azure Pipelines successfully started running 1 pipeline(s). |
bingwang-ms
approved these changes
Jul 22, 2024
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Jul 22, 2024
Change-Id: I753593ed128bd4c6a6915bca8eebf788743d2bd5
Collaborator
|
Cherry-pick PR to 202311: #13754 |
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Jul 22, 2024
Change-Id: I753593ed128bd4c6a6915bca8eebf788743d2bd5
Collaborator
|
Cherry-pick PR to 202405: #13755 |
This was referenced Jul 22, 2024
mssonicbld
pushed a commit
that referenced
this pull request
Jul 22, 2024
mssonicbld
pushed a commit
that referenced
this pull request
Jul 22, 2024
arista-hpandya
pushed a commit
to arista-hpandya/sonic-mgmt
that referenced
this pull request
Oct 2, 2024
Change-Id: I753593ed128bd4c6a6915bca8eebf788743d2bd5
vikshaw-Nokia
pushed a commit
to vikshaw-Nokia/sonic-mgmt
that referenced
this pull request
Oct 23, 2024
Change-Id: I753593ed128bd4c6a6915bca8eebf788743d2bd5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
revert #11763
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
Revert the set_speed function in #11763
For onyx fanout, we don't need to specify the lane number when setting speed. It will sync with dut automatically.
In #11763, It will select the smallest lane 1, but some platforms don't support the smallest lane 1, so it will cause port not up. So we should let fanout sync with dut automatically.
How did you do it?
Revert it
How did you verify/test it?
Run it on setup with onyx
Any platform specific information?
mellanox
Supported testbed topology if it's a new test case?
Documentation