[Mellanox] Improve the setting speed function for onyx fanout#11763
Merged
bingwang-ms merged 1 commit intosonic-net:masterfrom Mar 4, 2024
Merged
[Mellanox] Improve the setting speed function for onyx fanout#11763bingwang-ms merged 1 commit intosonic-net:masterfrom
bingwang-ms merged 1 commit intosonic-net:masterfrom
Conversation
The speed support list for onyx is like '1G 10G 25G 40G 50Gx1 50Gx2 100Gx2 100Gx4 200Gx4'. When the fanout is onyx, we need to set the speed according to the speed support list. For example, when dut and fanout all support 50G, if support speed list of fanout just includes 50Gx1 not includes 50G, we need to set the speed with 50Gx1 instead of 50G, otherwise, the port can not be up. Change-Id: I5d14151422fc10ee23fd410d999278cff59ff52b
nhe-NV
approved these changes
Feb 23, 2024
bingwang-ms
approved these changes
Mar 4, 2024
Collaborator
|
LGTM. |
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Mar 22, 2024
The speed support list for onyx is like '1G 10G 25G 40G 50Gx1 50Gx2 100Gx2 100Gx4 200Gx4'. When the fanout is onyx, we need to set the speed according to the speed support list. For example, when dut and fanout all support 50G, if support speed list of fanout just includes 50Gx1 not includes 50G, we need to set the speed with 50Gx1 instead of 50G, otherwise, the port can not be up. Change-Id: I5d14151422fc10ee23fd410d999278cff59ff52b
Collaborator
|
Cherry-pick PR to 202311: #12107 |
8 tasks
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Mar 22, 2024
The speed support list for onyx is like '1G 10G 25G 40G 50Gx1 50Gx2 100Gx2 100Gx4 200Gx4'. When the fanout is onyx, we need to set the speed according to the speed support list. For example, when dut and fanout all support 50G, if support speed list of fanout just includes 50Gx1 not includes 50G, we need to set the speed with 50Gx1 instead of 50G, otherwise, the port can not be up. Change-Id: I5d14151422fc10ee23fd410d999278cff59ff52b
Collaborator
|
Cherry-pick PR to 202305: #12108 |
8 tasks
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Mar 22, 2024
The speed support list for onyx is like '1G 10G 25G 40G 50Gx1 50Gx2 100Gx2 100Gx4 200Gx4'. When the fanout is onyx, we need to set the speed according to the speed support list. For example, when dut and fanout all support 50G, if support speed list of fanout just includes 50Gx1 not includes 50G, we need to set the speed with 50Gx1 instead of 50G, otherwise, the port can not be up. Change-Id: I5d14151422fc10ee23fd410d999278cff59ff52b
Collaborator
|
Cherry-pick PR to 202205: #12109 |
8 tasks
mssonicbld
pushed a commit
that referenced
this pull request
Mar 22, 2024
The speed support list for onyx is like '1G 10G 25G 40G 50Gx1 50Gx2 100Gx2 100Gx4 200Gx4'. When the fanout is onyx, we need to set the speed according to the speed support list. For example, when dut and fanout all support 50G, if support speed list of fanout just includes 50Gx1 not includes 50G, we need to set the speed with 50Gx1 instead of 50G, otherwise, the port can not be up. Change-Id: I5d14151422fc10ee23fd410d999278cff59ff52b
mssonicbld
pushed a commit
that referenced
this pull request
Mar 22, 2024
The speed support list for onyx is like '1G 10G 25G 40G 50Gx1 50Gx2 100Gx2 100Gx4 200Gx4'. When the fanout is onyx, we need to set the speed according to the speed support list. For example, when dut and fanout all support 50G, if support speed list of fanout just includes 50Gx1 not includes 50G, we need to set the speed with 50Gx1 instead of 50G, otherwise, the port can not be up. Change-Id: I5d14151422fc10ee23fd410d999278cff59ff52b
mssonicbld
pushed a commit
that referenced
this pull request
Mar 22, 2024
The speed support list for onyx is like '1G 10G 25G 40G 50Gx1 50Gx2 100Gx2 100Gx4 200Gx4'. When the fanout is onyx, we need to set the speed according to the speed support list. For example, when dut and fanout all support 50G, if support speed list of fanout just includes 50Gx1 not includes 50G, we need to set the speed with 50Gx1 instead of 50G, otherwise, the port can not be up. Change-Id: I5d14151422fc10ee23fd410d999278cff59ff52b
mssonicbld
added
Included in 202311 branch
and removed
Created PR to 202311 branch
labels
JibinBao
added a commit
to JibinBao/sonic-mgmt
that referenced
this pull request
Jul 12, 2024
Change-Id: I753593ed128bd4c6a6915bca8eebf788743d2bd5
8 tasks
bingwang-ms
pushed a commit
that referenced
this pull request
Jul 22, 2024
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Jul 22, 2024
Change-Id: I753593ed128bd4c6a6915bca8eebf788743d2bd5
8 tasks
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Jul 22, 2024
Change-Id: I753593ed128bd4c6a6915bca8eebf788743d2bd5
8 tasks
mssonicbld
pushed a commit
that referenced
this pull request
Jul 22, 2024
mssonicbld
pushed a commit
that referenced
this pull request
Jul 22, 2024
arista-hpandya
pushed a commit
to arista-hpandya/sonic-mgmt
that referenced
this pull request
Oct 2, 2024
Change-Id: I753593ed128bd4c6a6915bca8eebf788743d2bd5
vikshaw-Nokia
pushed a commit
to vikshaw-Nokia/sonic-mgmt
that referenced
this pull request
Oct 23, 2024
Change-Id: I753593ed128bd4c6a6915bca8eebf788743d2bd5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
The speed support list for onyx is like '1G 10G 25G 40G 50Gx1 50Gx2 100Gx2 100Gx4 200Gx4'. When the fanout is onyx, we need to set the speed according to the speed support list.
For example, when dut and fanout all support 50G, if the support speed list of fanout just includes 50Gx1 not includes 50G, we need to set the speed with 50Gx1 instead of 50G, otherwise, the port can not be up.
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
Improve the setting speed function for onyx fanout
How did you do it?
Select the match speed from the support speed list
How did you verify/test it?
Run testQosSaiDwrr with onyx fanout
Any platform specific information?
Any
Supported testbed topology if it's a new test case?
Documentation