Skip to content

Remove skip condition for test_syslog_source_ip#13301

Merged
StormLiangMS merged 1 commit intosonic-net:202311from
JibinBao:remove_skip_condition_for_syslog_tests
Jul 15, 2024
Merged

Remove skip condition for test_syslog_source_ip#13301
StormLiangMS merged 1 commit intosonic-net:202311from
JibinBao:remove_skip_condition_for_syslog_tests

Conversation

@JibinBao
Copy link
Contributor

Description of PR

Remove skip condition for test_syslog_source_ip, bcause the relevant bug of #6479 has been fixed

Summary:
Fixes # (issue)

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 202012
  • 202205
  • 202305
  • 202311
  • 202405

Approach

What is the motivation for this PR?

Remove skip condition for test_syslog_source_ip

How did you do it?

Remove skip condition

How did you verify/test it?

Run test_syslog_source_ip tests

Any platform specific information?

Any

Supported testbed topology if it's a new test case?

Documentation

Change-Id: Ife118ebd9d37518daede80a1c1b8846ec42e9982
Copy link
Collaborator

@StormLiangMS StormLiangMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@StormLiangMS
Copy link
Collaborator

hi @JibinBao could you also create PR for master branch?

@StormLiangMS StormLiangMS merged commit 0935b9d into sonic-net:202311 Jul 15, 2024
@JibinBao
Copy link
Contributor Author

hi @JibinBao could you also create PR for master branch?

will do

@StormLiangMS
Copy link
Collaborator

still causing error, reverted, let's fix all issues before get this back. @JibinBao
failed on teardown with "Failed: Processes "['analyze_logs--']" failed with exit code "1"
Exception:
match: 1
expected_match: 0
expected_missing_match: 0

Match Messages:
Jul 17 05:07:10.213900 bjw-can-2700-3 ERR monit[512]: 'routeCheck' status failed (255) -- Failure results: {{#12 "missed_INTF_TABLE_entries": [#12 "200.200.200.2/32",#12 "2221::1112/128"#12 ]#12}}#012Failed. Look at reported mismatches above#012add: []#012del: []

Traceback:
Traceback (most recent call last):
File "/var/src/sonic-mgmt_testbed-bjw-can-2700-3_646f1407735219c3e5444112/tests/common/helpers/parallel.py", line 35, in run
Process.run(self)
File "/usr/lib/python3.8/multiprocessing/process.py", line 108, in run
self._target(*self._args, **self._kwargs)
File "/var/src/sonic-mgmt_testbed-bjw-can-2700-3_646f1407735219c3e5444112/tests/common/helpers/parallel.py", line 245, in wrapper
target(*args, **kwargs)
File "/var/src/sonic-mgmt_testbed-bjw-can-2700-3_646

@JibinBao
Copy link
Contributor Author

@StormLiangMS , does the logs happen on 202311 branch?

  1. we did't have see the log error in 202311.
  2. The log error is not related the bug of [sonic-mgmt] test case failure syslog.test_syslog_source_ip.TestSSIP  #6479
  3. The logs happens on master branch only when inlucding the PR of added testplan for syslog protocol, filter, trap severity level #11803
  4. So I think we should close the bug of [sonic-mgmt] test case failure syslog.test_syslog_source_ip.TestSSIP  #6479. As for the error, it should be handled by other tikcet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants