Skip to content

added testplan for syslog protocol, filter, trap severity level#11803

Merged
qiluo-msft merged 4 commits intosonic-net:masterfrom
SvyatDemn:syslog_capabilities_tests
Mar 24, 2024
Merged

added testplan for syslog protocol, filter, trap severity level#11803
qiluo-msft merged 4 commits intosonic-net:masterfrom
SvyatDemn:syslog_capabilities_tests

Conversation

@SvyatDemn
Copy link
Contributor

@SvyatDemn SvyatDemn commented Feb 28, 2024

Description of PR

  • Adding a new test plan and test for syslog protocol, filter, trap severity level

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 201911
  • 202012
  • 202205
  • 202305
  • 202311

Approach

What is the motivation for this PR?

Adding a new test plan document and tests.

How did you do it?

Created an MD file with the test plan information.

How did you verify/test it?

N/A

Any platform specific information?

N/A

Supported testbed topology if it's a new test case?

N/A

Documentation

N/A

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Feb 28, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

@yxieca
Copy link
Collaborator

yxieca commented Feb 28, 2024

@SvyatDemn please sign the EasyCLA.

@SvyatDemn
Copy link
Contributor Author

@SvyatDemn please sign the EasyCLA.

Hi, did it many times, doesn't work for me, created a ticket for that
https://jira.linuxfoundation.org/plugins/servlet/desk/portal/4/SUPPORT-25419

@SvyatDemn SvyatDemn force-pushed the syslog_capabilities_tests branch from c7588ef to 01da29b Compare March 19, 2024 00:02
@SvyatDemn SvyatDemn force-pushed the syslog_capabilities_tests branch from f545658 to c5031b1 Compare March 19, 2024 00:16
@SvyatDemn
Copy link
Contributor Author

@SvyatDemn please sign the EasyCLA.

Done with Easy CLA, please review

@mssonicbld
Copy link
Collaborator

The pre-commit check detected issues in the files touched by this pull request.
The pre-commit check is a mandatory check, please fix detected issues.

Detailed pre-commit check results:
trim trailing whitespace.................................................Passed
fix end of files.........................................................Passed
check yaml...........................................(no files to check)Skipped
check for added large files..............................................Passed
check python ast.........................................................Passed
flake8...................................................................Failed
- hook id: flake8
- exit code: 1

tests/syslog/test_syslog_source_ip.py:7:1: F401 'time' imported but unused
tests/syslog/test_syslog_source_ip.py:657:33: E127 continuation line over-indented for visual indent
tests/syslog/test_syslog_source_ip.py:675:33: E127 continuation line over-indented for visual indent
tests/syslog/test_syslog_source_ip.py:693:33: E127 continuation line over-indented for visual indent
tests/syslog/test_syslog_source_ip.py:696:34: E127 continuation line over-indented for visual indent

flake8...............................................(no files to check)Skipped
check conditional mark sort..........................(no files to check)Skipped

To run the pre-commit checks locally, you can follow below steps:

  1. Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run
    the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt
    docker container.
  2. Ensure that the pre-commit package is installed:
sudo pip install pre-commit
  1. Go to repository root folder
  2. Install the pre-commit hooks:
pre-commit install
  1. Use pre-commit to check staged file:
pre-commit
  1. Alternatively, you can check committed files using:
pre-commit run --from-ref <commit_id> --to-ref <commit_id>

@SvyatDemn SvyatDemn force-pushed the syslog_capabilities_tests branch from be0adb6 to fb4873f Compare March 20, 2024 09:06
@mssonicbld
Copy link
Collaborator

The pre-commit check detected issues in the files touched by this pull request.
The pre-commit check is a mandatory check, please fix detected issues.

Detailed pre-commit check results:
trim trailing whitespace.................................................Passed
fix end of files.........................................................Passed
check yaml...........................................(no files to check)Skipped
check for added large files..............................................Passed
check python ast.........................................................Passed
flake8...................................................................Failed
- hook id: flake8
- exit code: 1

tests/syslog/test_syslog_source_ip.py:657:17: E122 continuation line missing indentation or outdented
tests/syslog/test_syslog_source_ip.py:676:17: E122 continuation line missing indentation or outdented
tests/syslog/test_syslog_source_ip.py:697:34: E127 continuation line over-indented for visual indent

flake8...............................................(no files to check)Skipped
check conditional mark sort..........................(no files to check)Skipped

To run the pre-commit checks locally, you can follow below steps:

  1. Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run
    the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt
    docker container.
  2. Ensure that the pre-commit package is installed:
sudo pip install pre-commit
  1. Go to repository root folder
  2. Install the pre-commit hooks:
pre-commit install
  1. Use pre-commit to check staged file:
pre-commit
  1. Alternatively, you can check committed files using:
pre-commit run --from-ref <commit_id> --to-ref <commit_id>

@SvyatDemn SvyatDemn force-pushed the syslog_capabilities_tests branch from fb4873f to 27ed83c Compare March 20, 2024 09:25
@qiluo-msft qiluo-msft merged commit 6c558d2 into sonic-net:master Mar 24, 2024
@JibinBao
Copy link
Contributor

Hi @SvyatDemn , does the branch 202311 support the test?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants