Skip to content

Revert "Added temporary skip to system_health TC for MLX platfroms "#13136

Merged
bingwang-ms merged 1 commit intosonic-net:masterfrom
JibinBao:revert_skip_device_checker
Jul 23, 2024
Merged

Revert "Added temporary skip to system_health TC for MLX platfroms "#13136
bingwang-ms merged 1 commit intosonic-net:masterfrom
JibinBao:revert_skip_device_checker

Conversation

@JibinBao
Copy link
Contributor

@JibinBao JibinBao commented Jun 5, 2024

Description of PR

Revert "Added temporary skip to system_health TC for MLX platfroms " #12798, because there is a fix: #12895

Summary:
Fixes # (issue)

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 201911
  • 202012
  • 202205
  • 202305
  • 202311

Approach

What is the motivation for this PR?

Remove the skip condition

How did you do it?

Remove it

How did you verify/test it?

Run test_device_checker

Any platform specific information?

Mellanox

Supported testbed topology if it's a new test case?

Documentation

@JibinBao JibinBao changed the title Revert "Added temporary skip to system_health TC for MLX platfroms Revert "Added temporary skip to system_health TC for MLX platfroms " Jun 5, 2024
@bingwang-ms
Copy link
Collaborator

Re-triggered PR test.

@bingwang-ms
Copy link
Collaborator

Merge is on-hold because PR #12895 is not merged into 202311 and 202405 yet.

@JibinBao
Copy link
Contributor Author

Merge is on-hold because PR #12895 is not merged into 202311 and 202405 yet.

cherry-pick to 202311, please help review :#13760

@bingwang-ms bingwang-ms merged commit 4543e3f into sonic-net:master Jul 23, 2024
mssonicbld pushed a commit to mssonicbld/sonic-mgmt that referenced this pull request Jul 23, 2024
@bingwang-ms
Copy link
Collaborator

@JibinBao Please check if the PR is required for 202405 branch. Thanks

@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202311: #13773

@JibinBao
Copy link
Contributor Author

@JibinBao Please check if the PR is required for 202405 branch. Thanks

Yes. 202405 also need it.

@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202405: #13781

arista-hpandya pushed a commit to arista-hpandya/sonic-mgmt that referenced this pull request Oct 2, 2024
vikshaw-Nokia pushed a commit to vikshaw-Nokia/sonic-mgmt that referenced this pull request Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants