[Mellanox] Skip asic mock in test_device_checker for mellanox device#12895
Merged
bingwang-ms merged 1 commit intosonic-net:masterfrom Jun 4, 2024
Merged
[Mellanox] Skip asic mock in test_device_checker for mellanox device#12895bingwang-ms merged 1 commit intosonic-net:masterfrom
bingwang-ms merged 1 commit intosonic-net:masterfrom
Conversation
…8455 For mellanox device, skip asic mock, because the asic soft link has been moved to sdk sysfs Change-Id: I2839c6289dfb1a010cc02a00dfd4409d9a5233be
nhe-NV
approved these changes
May 26, 2024
Contributor
Contributor
Author
Collaborator
|
LGTM. Thanks for the fix. |
bingwang-ms
approved these changes
Jun 4, 2024
8 tasks
Contributor
Author
|
Hi @bingwang-ms, |
mrkcmo
pushed a commit
to Azarack/sonic-mgmt
that referenced
this pull request
Jul 17, 2024
…8455 (sonic-net#12895) For mellanox device, skip asic mock, because the asic soft link has been moved to sdk sysfs Change-Id: I2839c6289dfb1a010cc02a00dfd4409d9a5233be
Collaborator
|
@JibinBao PR conflicts with 202311 branch |
Collaborator
|
@JibinBao Please address the conflict for 202311. Do we need this fix for 202405 as well? |
Contributor
Author
202405 also need it. |
JibinBao
added a commit
to JibinBao/sonic-mgmt
that referenced
this pull request
Jul 23, 2024
…8455 (sonic-net#12895) For mellanox device, skip asic mock, because the asic soft link has been moved to sdk sysfs Change-Id: I2839c6289dfb1a010cc02a00dfd4409d9a5233be
Contributor
Author
|
@bingwang-ms |
Collaborator
|
@JibinBao Please double check if the change is also required on 202405 branch. |
Merged
8 tasks
Contributor
Author
|
Merged
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
For mellanox device, skip asic mock, because the asic soft link has been moved to sdk sysfs, and there is no way to mock asic.
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
Skip asic mock on mellanox device
How did you do it?
Skip asic mock when device is mellanox
How did you verify/test it?
Run test on mellanox device
Any platform specific information?
Mellanox
Supported testbed topology if it's a new test case?
Any
Documentation