[sdn_tests]: Adding Build support for pins_ondatra.#12658
[sdn_tests]: Adding Build support for pins_ondatra.#12658vamsipunati merged 1 commit intosonic-net:masterfrom
Conversation
sdn_tests/pins_ondatra/pins_deps.bzl
Outdated
| git_repository( | ||
| name = "sonic_swss_common", | ||
| commit = "672b1cfe1914489b79a91fff8a539b6c195f8959", | ||
| remote = "git@github.com:pins/sonic-swss-common.git", |
There was a problem hiding this comment.
@parth-opensrc What would be the sonic-net equivalent commit id ? We can't use PINS refpt here.
There was a problem hiding this comment.
I think this repo may not be needed for ondatra, so can be removed for now.
I will clean up this file in future.
There was a problem hiding this comment.
@VSuryaprasad-HCL Can you remove this and re-attach the pass build logs.
There was a problem hiding this comment.
I have addressed the changes and reattached the build log.
There was a problem hiding this comment.
@VSuryaprasad-HCL Getting a 404 error on this url ? Maybe we haven't added the build targets that exercise this to cause a failure ?
cc: @parth-opensrc
There was a problem hiding this comment.
Try removing it, if the build works, it should be fine to remove the dep.
If it doesn't, you can try changing the rule:
go_repository(
name = "com_github_jstemmer_go_junit_report_v2",
commit = "add_commit_hash",
importpath = "github.com/jstemmer/go-junit-report/v2",
remote = "https://github.com/jstemmer/go-junit-report",
vcs = "git"
)
There was a problem hiding this comment.
@parth-opensrc Tried removing the dep, The build was successful. Attaching the build info in the chat box.
INFO: Analyzed 0 targets (1 packages loaded, 0 targets configured).
INFO: Found 0 targets...
INFO: Elapsed time: 2.596s, Critical Path: 0.02s
INFO: 1 process: 1 internal.
INFO: Build completed successfully, 1 total action
There was a problem hiding this comment.
@vamsipunati, @parth-opensrc
This and the previous one, are we ok to include these as dependencies in sonic-net ?
There was a problem hiding this comment.
Try removing the rules, if ondatra builds, then it should be okay to remove.
Ondatra uses these deps:
https://github.com/openconfig/ondatra/blob/main/internal/ixgnmi/ixgnmi.go#L39, and
https://github.com/openconfig/ondatra/blob/main/report/report_test.go#L23
We are using checksum, so it should be fine even if the deps aren't removed.
There was a problem hiding this comment.
@parth-opensrc Tried removing the rules, The build was successful. Attaching the build info in the chat box
INFO: Analyzed 0 targets (1 packages loaded, 0 targets configured).
INFO: Found 0 targets...
INFO: Elapsed time: 0.593s, Critical Path: 0.00s
INFO: 1 process: 1 internal.
INFO: Build completed successfully, 1 total action
5 participants
Description of PR
[sdn_tests]: Adding Build support for pins_ondatra.
Summary:
Build Result:
Type of change
Back port request
Approach
What is the motivation for this PR?
How did you do it?
How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation