Skip to content

SDN Test framework for SONiC#11771

Merged
yxieca merged 1 commit intomasterfrom
ondatra
Mar 5, 2024
Merged

SDN Test framework for SONiC#11771
yxieca merged 1 commit intomasterfrom
ondatra

Conversation

@vamsipunati
Copy link
Contributor

Description of PR

Created subdirectory sdn_tests. Added a readme and topology document to cover Ondatra test framework to test SONiC images. We will add tests in subsequent commits.

Summary:
Fixes # (issue)

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 201911
  • 202012
  • 202205
  • 202305
  • 202311

Approach

What is the motivation for this PR?

Ondatra is an open-source framework. We plan to contribute tests developed with it to the SONiC community.

How did you do it?

How did you verify/test it?

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Feb 26, 2024

CLA Signed


The committers listed above are authorized under a signed CLA.

@mssonicbld
Copy link
Collaborator

The pre-commit check detected issues in the files touched by this pull request.
The pre-commit check is a mandatory check, please fix detected issues.

Detailed pre-commit check results:
trim trailing whitespace.................................................Failed
- hook id: trailing-whitespace
- exit code: 1
- files were modified by this hook

Fixing sdn_tests/readme.md

fix end of files.........................................................Passed
check yaml...........................................(no files to check)Skipped
check for added large files..............................................Passed
check python ast.....................................(no files to check)Skipped
flake8...............................................(no files to check)Skipped
flake8...............................................(no files to check)Skipped
check conditional mark sort..........................(no files to check)Skipped

To run the pre-commit checks locally, you can follow below steps:

  1. Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run
    the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt
    docker container.
  2. Ensure that the pre-commit package is installed:
sudo pip install pre-commit
  1. Go to repository root folder
  2. Install the pre-commit hooks:
pre-commit install
  1. Use pre-commit to check staged file:
pre-commit
  1. Alternatively, you can check committed files using:
pre-commit run --from-ref <commit_id> --to-ref <commit_id>

@vamsipunati
Copy link
Contributor Author

CLA Not Signed

@yxieca It is not allowing me to submit as corporate contributor. Can you help me with this?

- Description of PR
Created subdirectory sdn_tests. Added a readme and topology document to cover Ondatra test framework to test SONiC images. We will add tests in subsequent commits.

Summary:
Fixes # (issue)

- Type of change

- [ ] Bug fix
- [x] Testbed and Framework(new/improvement)
- [ ] Test case(new/improvement)

- Back port request
- [ ] 201911
- [ ] 202012
- [ ] 202205
- [ ] 202305
- [ ] 202311

-  Approach
-  What is the motivation for this PR?
Ondatra is an open-source framework. We plan to contribute tests developed with it to the SONiC community.
-  How did you do it?

-  How did you verify/test it?

-  Any platform specific information?

-  Supported testbed topology if it's a new test case?

-  Documentation

Signed-off-by: vamsipunati <[email protected]>
@yxieca
Copy link
Collaborator

yxieca commented Feb 28, 2024

CLA Not Signed

@yxieca It is not allowing me to submit as corporate contributor. Can you help me with this?

@vamsipunati I believe you will need to sign EasyCLA as individual contributor instead of Corp contributor.

@vamsipunati
Copy link
Contributor Author

Thanks @yxieca. I signed as individual contributor. Can you please review now?

@yxieca yxieca merged commit 533fa80 into master Mar 5, 2024
@yxieca yxieca deleted the ondatra branch March 5, 2024 18:17
@kishanps
Copy link
Contributor

Tagged for 202405 release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants