Add check of dut type and kvm support flag in ptf_runner#12598
Merged
wangxin merged 6 commits intosonic-net:masterfrom May 8, 2024
Merged
Add check of dut type and kvm support flag in ptf_runner#12598wangxin merged 6 commits intosonic-net:masterfrom
wangxin merged 6 commits intosonic-net:masterfrom
Conversation
wangxin
reviewed
Apr 26, 2024
tests/ptf_runner.py
Outdated
|
|
||
|
|
||
| def get_dut_type(host): | ||
| dut_type_exists = host.stat(path="/sonic/dut_type.txt") |
Collaborator
There was a problem hiding this comment.
This variable indeed holds "stat" of file /sonic/dut_type.txt. It means more than just "exists". Maybe dut_type_stat is a better variable name?
wangxin
approved these changes
May 8, 2024
8 tasks
wangxin
pushed a commit
that referenced
this pull request
Nov 7, 2024
What is the motivation for this PR? In PR #12598, we set default kvm_support to True in ptf_runner params, but most of tests do not support traffic test in KVM, to minimize code change in testcases, it's better to set default kvm_support to False How did you do it? Set default kvm_support to False and set kvm_support to True in tests currently running ptf_runner How did you verify/test it?
veronica-arista
pushed a commit
to veronica-arista/sonic-mgmt
that referenced
this pull request
Nov 7, 2024
What is the motivation for this PR? In PR sonic-net#12598, we set default kvm_support to True in ptf_runner params, but most of tests do not support traffic test in KVM, to minimize code change in testcases, it's better to set default kvm_support to False How did you do it? Set default kvm_support to False and set kvm_support to True in tests currently running ptf_runner How did you verify/test it?
sreejithsreekumaran
pushed a commit
to sreejithsreekumaran/sonic-mgmt
that referenced
this pull request
Nov 15, 2024
What is the motivation for this PR? In PR sonic-net#12598, we set default kvm_support to True in ptf_runner params, but most of tests do not support traffic test in KVM, to minimize code change in testcases, it's better to set default kvm_support to False How did you do it? Set default kvm_support to False and set kvm_support to True in tests currently running ptf_runner How did you verify/test it?
yutongzhang-microsoft
pushed a commit
to yutongzhang-microsoft/sonic-mgmt
that referenced
this pull request
Nov 21, 2024
What is the motivation for this PR? In PR sonic-net#12598, we set default kvm_support to True in ptf_runner params, but most of tests do not support traffic test in KVM, to minimize code change in testcases, it's better to set default kvm_support to False How did you do it? Set default kvm_support to False and set kvm_support to True in tests currently running ptf_runner How did you verify/test it?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
We are adding more data plane test scripts to PR test, but some traffic test using ptf_runner can't be tested on KVM platform, we need to test configuration and skip ptf_runner test if needed
It's a better approach to get dut type in ptf_runner and use a flag to decide whether the case could be run on KVM dut, and dut type already stored in ptf with PR #12588
How did you do it?
How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation