Merged
Conversation
wangxin
approved these changes
Apr 26, 2024
Collaborator
|
Can you improve the PR description to elaborate the motivation and thinking behind this PR? |
Contributor
Author
Updated |
8 tasks
wangxin
pushed a commit
that referenced
this pull request
May 8, 2024
What is the motivation for this PR? We are adding more data plane test scripts to PR test, but some traffic test using ptf_runner can't be tested on KVM platform, we need to test configuration and skip ptf_runner test if needed It's a better approach to get dut type in ptf_runner and use a flag to decide whether the case could be run on KVM dut, and dut type already stored in ptf with PR #12588 How did you do it? 1. Get dut_type and kvm_support flag at the beginning of ptf runner, if dut is kvm and kvm_support is false, return True to skip ptf_runner test 2. Consider default kvm_support is True, because some data plane tests in pr test require to run ptf_runner, and test result are also related to the behavior of ptf, so set default to True and will add False if new data plane test do not support kvm platform
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
We are adding more data plane test scripts to PR test, but some traffic test using ptf_runner can't be tested on KVM platform, we need to test configuration and skip ptf_runner test if needed
To minimize the change on testcases, it's a better approach to get dut type in ptf_runner and use a flag to decide whether the case could be run on KVM dut, other than add if else in all testcases using ptf_runner
How did you do it?
Store dut type to file in ptf host in add-top and restart-ptf, then we will be able to get dut type in ptf_runner
How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation