Skip to content

Add topology mark in the module already in PR test#12390

Merged
wangxin merged 3 commits intosonic-net:masterfrom
yutongzhang-microsoft:yutongzhang/add_correct_mark
Apr 16, 2024
Merged

Add topology mark in the module already in PR test#12390
wangxin merged 3 commits intosonic-net:masterfrom
yutongzhang-microsoft:yutongzhang/add_correct_mark

Conversation

@yutongzhang-microsoft
Copy link
Copy Markdown
Contributor

@yutongzhang-microsoft yutongzhang-microsoft commented Apr 10, 2024

Description of PR

In our pytest, it's crucial to have proper markers for different test topologies to ensure that tests are run in the correct testbeds. It seems that some modules, despite having passed the PR tests, lack the necessary topology markers. In this PR, we add the missing markers, which will enhance the clarity and efficiency of the testing process and ensure that each module is tested on the appropriate testbeds.

Summary:
Fixes # (issue)

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 201911
  • 202012
  • 202205
  • 202305
  • 202311

Approach

What is the motivation for this PR?

In our pytest, it's crucial to have proper markers for different test topologies to ensure that tests are run in the correct testbeds. It seems that some modules, despite having passed the PR tests, lack the necessary topology markers. In this PR, we add the missing markers, which will enhance the clarity and efficiency of the testing process and ensure that each module is tested on the appropriate testbeds.

How did you do it?

How did you verify/test it?

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

@yutongzhang-microsoft yutongzhang-microsoft changed the title Add correct pytest mark in modue which is already existing in PR test. Add topology mark in the module already in PR test Apr 12, 2024
@wangxin wangxin merged commit c2376ef into sonic-net:master Apr 16, 2024
mssonicbld pushed a commit to mssonicbld/sonic-mgmt that referenced this pull request Apr 16, 2024
What is the motivation for this PR?
In our pytest, it's mandatory to have proper markers for different test topologies to ensure that tests are run in the correct testbeds. It seems that some modules, despite having passed the PR tests, lack the necessary topology markers. In this PR, we add the missing markers, which will enhance the clarity and efficiency of the testing process and ensure that each module is tested on the appropriate testbeds.
@mssonicbld
Copy link
Copy Markdown
Collaborator

Cherry-pick PR to 202311: #12464

mssonicbld pushed a commit to mssonicbld/sonic-mgmt that referenced this pull request Apr 16, 2024
What is the motivation for this PR?
In our pytest, it's mandatory to have proper markers for different test topologies to ensure that tests are run in the correct testbeds. It seems that some modules, despite having passed the PR tests, lack the necessary topology markers. In this PR, we add the missing markers, which will enhance the clarity and efficiency of the testing process and ensure that each module is tested on the appropriate testbeds.
@mssonicbld
Copy link
Copy Markdown
Collaborator

Cherry-pick PR to 202305: #12465

@yutongzhang-microsoft yutongzhang-microsoft deleted the yutongzhang/add_correct_mark branch April 16, 2024 07:41
mssonicbld pushed a commit that referenced this pull request Apr 16, 2024
What is the motivation for this PR?
In our pytest, it's mandatory to have proper markers for different test topologies to ensure that tests are run in the correct testbeds. It seems that some modules, despite having passed the PR tests, lack the necessary topology markers. In this PR, we add the missing markers, which will enhance the clarity and efficiency of the testing process and ensure that each module is tested on the appropriate testbeds.
mssonicbld pushed a commit that referenced this pull request Apr 16, 2024
What is the motivation for this PR?
In our pytest, it's mandatory to have proper markers for different test topologies to ensure that tests are run in the correct testbeds. It seems that some modules, despite having passed the PR tests, lack the necessary topology markers. In this PR, we add the missing markers, which will enhance the clarity and efficiency of the testing process and ensure that each module is tested on the appropriate testbeds.
@bingwang-ms
Copy link
Copy Markdown
Collaborator

bingwang-ms commented May 2, 2024

@yutongzhang-microsoft The test case arp/test_neighbor_mac.py::TestNeighborMac::testNeighborMac is not ready for T0. We are seeing consistent failure on T0 testbed. Can you revert the change for this particular case?

  • The test case hardcoded Ethernet0 for testing, but Ethernet0 is admin down on some T0 topo
  • If Ethernet0 belongs to vlan port, config interface ip command returns error
~$ sudo config interface ip add Ethernet0 20.0.0.1/24
Interface Ethernet0 is a member of vlan
Aborting!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants