Revert "[IPv6 only]Fixture to convert/revert the mgmt-ip to IPv6 olny, enhance connection plugin"#11987
Closed
yejianquan wants to merge 1 commit intomasterfrom
Closed
Revert "[IPv6 only]Fixture to convert/revert the mgmt-ip to IPv6 olny, enhance connection plugin"#11987yejianquan wants to merge 1 commit intomasterfrom
yejianquan wants to merge 1 commit intomasterfrom
Conversation
… enhance…" This reverts commit afd7fce.
wangxin
approved these changes
Mar 14, 2024
Collaborator
|
Please explain the reason of reverting this change in PR description. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #11957
In the starlab, the 2 IPv6 subnet can't ping each other,
So the dut could lost connection after changed, this PR could result in huge nightly failure.
Better to polish the fixture to detect the availability of IPv6 before changing.