[IPv6 only]Fixture to convert/revert the mgmt-ip to IPv6 olny, enhance connection plugin#11957
Conversation
|
The pre-commit check detected issues in the files touched by this pull request. Detailed pre-commit check results: To run the pre-commit checks locally, you can follow below steps:
|
|
The pre-commit check detected issues in the files touched by this pull request. Detailed pre-commit check results: To run the pre-commit checks locally, you can follow below steps:
|
|
The pre-commit check detected issues in the files touched by this pull request. Detailed pre-commit check results: To run the pre-commit checks locally, you can follow below steps:
|
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
The pre-commit check detected issues in the files touched by this pull request. Detailed pre-commit check results: To run the pre-commit checks locally, you can follow below steps:
|
|
PR title is so long. Can you make the title shorter? |
… the connection plugin to retry with IPv6 addr if IPv4 addr is unavailable
e238b9b to
f75db3c
Compare
|
@yejianquan PR conflicts with 202305 branch |
|
@yejianquan PR conflicts with 202311 branch |
… the connection plugin to retry with IPv6 addr if IPv4 addr is unavailable (sonic-net#11957) Approach What is the motivation for this PR? Support test mgmt-ip IPv6 only scenario. How did you do it? Remove the IPv4 mgmt address before the test module starts, and restore after the test module is finished. Enhance the connection plugging to first connect with the IPv4 address, and retry with the IPv6 address if IPv4 is unavailable. Add a new test module with examples to test the IPv6-only scenario. How did you verify/test it? Run on physical testbeds, with dual-stack mgmt-ip addresses testbed and only with IPv6/IPv4 mgmt-ip address testbed. ================================================================================================================== test session starts ================================================================================================================== ip/test_mgmt_ipv6_only.py::test_bgp_facts[-None] PASSED [ 25%] ip/test_mgmt_ipv6_only.py::test_bgp_facts_ipv6_only[-None] PASSED [ 50%] ip/test_mgmt_ipv6_only.py::test_show_features[-4] PASSED [ 75%] ip/test_mgmt_ipv6_only.py::test_show_features_ipv6_only[-4] PASSED [100%] -- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html --------------------------------------------------------------------------------------------- generated xml file: /var/src/sonic-mgmt-int/tests/logs/tr.xml --------------------------------------------------------------------------------------------- ======================================================================================================= 4 passed, 3 warnings in 741.52s (0:12:21) ======================================================================================================= INFO:root:Can not get Allure report URL. Please check logs jianquanye@sonic-mgmt-jianquanye:/var/src/sonic-mgmt-int/tests$
|
Cherry-pick PR to 202311: #11983 |
… the connection plugin to retry with IPv6 addr if IPv4 addr is unavailable (sonic-net#11957) Approach What is the motivation for this PR? Support test mgmt-ip IPv6 only scenario. How did you do it? Remove the IPv4 mgmt address before the test module starts, and restore after the test module is finished. Enhance the connection plugging to first connect with the IPv4 address, and retry with the IPv6 address if IPv4 is unavailable. Add a new test module with examples to test the IPv6-only scenario. How did you verify/test it? Run on physical testbeds, with dual-stack mgmt-ip addresses testbed and only with IPv6/IPv4 mgmt-ip address testbed. ================================================================================================================== test session starts ================================================================================================================== ip/test_mgmt_ipv6_only.py::test_bgp_facts[-None] PASSED [ 25%] ip/test_mgmt_ipv6_only.py::test_bgp_facts_ipv6_only[-None] PASSED [ 50%] ip/test_mgmt_ipv6_only.py::test_show_features[-4] PASSED [ 75%] ip/test_mgmt_ipv6_only.py::test_show_features_ipv6_only[-4] PASSED [100%] -- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html --------------------------------------------------------------------------------------------- generated xml file: /var/src/sonic-mgmt-int/tests/logs/tr.xml --------------------------------------------------------------------------------------------- ======================================================================================================= 4 passed, 3 warnings in 741.52s (0:12:21) ======================================================================================================= INFO:root:Can not get Allure report URL. Please check logs jianquanye@sonic-mgmt-jianquanye:/var/src/sonic-mgmt-int/tests$
|
Cherry-pick PR to 202305: #11984 |
… enhance the connection plugin to retry with IPv6 addr if IPv4 addr is unavailable (sonic-net#11957)" This reverts commit afd7fce.
* Revert "[image_download] Add ipv6 only mgmt image download test (#11936)" This reverts commit f5cdac4. * Revert "[IPv6 only]Add a fixture to convert the DUT to IPv6 only, and enhance the connection plugin to retry with IPv6 addr if IPv4 addr is unavailable (#11957)" This reverts commit afd7fce. Approach What is the motivation for this PR? There's a performance impact introduced by the IPv6 fixture, the test time is getting longer. Revert and will create another PR after the performance issue is resolved.
Description of PR
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
Support test mgmt-ip IPv6 only scenario.
How did you do it?
Remove the IPv4 mgmt address before the test module starts, and restore after the test module is finished.
Enhance the connection plugging to first connect with the IPv4 address, and retry with the IPv6 address if IPv4 is unavailable.
Add a new test module with examples to test the IPv6-only scenario.
How did you verify/test it?
Run on physical testbeds, with dual-stack mgmt-ip addresses testbed and only with IPv6/IPv4 mgmt-ip address testbed.
================================================================================================================== test session starts ==================================================================================================================
ip/test_mgmt_ipv6_only.py::test_bgp_facts[-None] PASSED [ 25%]
ip/test_mgmt_ipv6_only.py::test_bgp_facts_ipv6_only[-None] PASSED [ 50%]
ip/test_mgmt_ipv6_only.py::test_show_features[-4] PASSED [ 75%]
ip/test_mgmt_ipv6_only.py::test_show_features_ipv6_only[-4] PASSED [100%]
-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
--------------------------------------------------------------------------------------------- generated xml file: /var/src/sonic-mgmt-int/tests/logs/tr.xml ---------------------------------------------------------------------------------------------
======================================================================================================= 4 passed, 3 warnings in 741.52s (0:12:21) =======================================================================================================
INFO:root:Can not get Allure report URL. Please check logs
jianquanye@sonic-mgmt-jianquanye:/var/src/sonic-mgmt-int/tests$
Any platform specific information?
No.
Supported testbed topology if it's a new test case?
All topologies.
Documentation