[sonicdocker] Change container task order due to service dependencies#118
Closed
NStetskovych-zz wants to merge 1 commit intosonic-net:masterfrom
Closed
[sonicdocker] Change container task order due to service dependencies#118NStetskovych-zz wants to merge 1 commit intosonic-net:masterfrom
NStetskovych-zz wants to merge 1 commit intosonic-net:masterfrom
Conversation
Signed-off-by: Nadiya.Stetskovych <[email protected]>
Contributor
|
Thanks for the fix. The issue is that currently syncd docker and swss docker are tightly coupled. They should really be under one systemd service control. In that system unit file, it should: Start sequence:
Stop sequence:
In terms of docker deployment, we should restart this single swss service whenever swss or syncd docker are updated. |
ansrajpu-git
pushed a commit
to ansrajpu-git/sonic-mgmt
that referenced
this pull request
Apr 14, 2025
sonic-net#16687 recently merged to fix an issue on non-chassis systems but it broke chassis systems as described in sonic-net#17131 This change will solve the issue originally targeted by sonic-net#16687 Where 'Ethernet112|6' when split with delimiter "|" the string in 1st index "6" is a substring of "Ethernet68" By using `val == interface` it no longer matters if the buffer queue matches up a substring of the interface. Summary: Fixes sonic-net#17131 ### Type of change - [x] Bug fix - [ ] Testbed and Framework(new/improvement) - [ ] New Test case - [ ] Skipped for non-supported platforms - [ ] Test case improvement ### Back port request - [ ] 202012 - [ ] 202205 - [ ] 202305 - [ ] 202311 - [x] 202405 - [x] 202411 ### Approach #### What is the motivation for this PR? #### How did you do it? #### How did you verify/test it? #### Any platform specific information? #### Supported testbed topology if it's a new test case? ### Documentation <!-- (If it's a new feature, new test case) Did you update documentation/Wiki relevant to your implementation? Link to the wiki page? -->
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
…atically (sonic-net#15543) #### Why I did it src/sonic-telemetry ``` * 56aa539 - (HEAD -> 202012, origin/202012) Fix sonic-mgmt-common version in pipeline build (sonic-net#124) (2 weeks ago) [Sachin Holla] * 4264949 - Change log level (sonic-net#118) (4 weeks ago) [Zain Budhwani] ```
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
…submodule head (sonic-net#11761) linkmgrd: * 476f85e 2022-08-17 | Update linkmgr health after getting default route update (sonic-net#117) (HEAD -> 202205, github/202205) [Longxiang Lyu] * fc589e9 2022-08-17 | Use `table` to toggle peer forwarding state (sonic-net#108) (sonic-net#120) [Longxiang Lyu] * bcb5a56 2022-08-17 | Fix azure pipeline (sonic-net#118) (sonic-net#121) [Longxiang Lyu] swss: * ef3a601 2022-08-17 | [muxorch] Returning true if nbr in skip_neighbor_ in isNeighborActive() (sonic-net#2415) (HEAD -> 202205) [Nikola Dancejic] sairedis: * aed01cd 2022-08-12 | Fix: missing sonic-db-cli in docker-sonic-vs image (sonic-net#1072) (sonic-net#1104) (github/202205) [Hua Liu] platform-daemon: * 5a68073 2022-08-01 | Xcvrd changes to support 400G ZR configuration (sonic-net#270) (HEAD -> 202205) [Prince George] swsssdk: * ca785a2 2022-06-01 | Remove sonic-db-cli (sonic-net#122) (HEAD -> 202205, origin/202205) [Hua Liu] Signed-off-by: Ying Xie <[email protected]> Signed-off-by: Ying Xie <[email protected]>
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
03936ea (HEAD -> 202111, origin/202111) define index for recirc port (sonic-net#118) d48f750 [port_util] Fix issue: port_util.get_vlan_interface_oid_map should not raise exception when DB has not RIF data (sonic-net#117)
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
commit 5f7cb77230fceb1b7fd30c57a70d0cd05cd6dd95 (HEAD -> 201911, origin/201911) Author: Sumukha Tumkur Vani <[email protected]> Date: Wed Jul 27 16:51:38 2022 -0700 Use 201911/stretch dependencies for build (sonic-net#118) commit e3809523050df75ec18bf31a5dc3a2e595d58a14 Author: Sumukha Tumkur Vani <[email protected]> Date: Wed Jul 27 15:17:12 2022 -0700 Change response message for conflicting VNI (sonic-net#117) Ref: sonic-net/sonic-restapi#99 Signed-off-by: Abhishek Dosi <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With #110 changes syncd service require swss.service.
So change task order that at the moment syncd starts swss.service has been generated.
Otherwise deployment fails on TASK [sonicv2 : syncd - Post docker - restart container service]
with message: "Failed to start syncd.service: Unit swss.service failed to load: No such file or directory"
Note: reproduce on "bare" onie as swss.service might have been generated before container dependencies introduced.
Signed-off-by: Nadiya.Stetskovych [email protected]