[pytest] Improve infra and update the platform scripts to use the new infra#1072
Merged
yxieca merged 5 commits intosonic-net:masterfrom Aug 22, 2019
wangxin:pytest-infra-platform
Merged
[pytest] Improve infra and update the platform scripts to use the new infra#1072yxieca merged 5 commits intosonic-net:masterfrom wangxin:pytest-infra-platform
yxieca merged 5 commits intosonic-net:masterfrom
wangxin:pytest-infra-platform
Conversation
… infra Improvements: * Add testbed_devices fixture * Add common folder for reusable libraries * Use OO design to abstract and encapsulate behavior for various devices in testbed * Improve code reuse by the OO design and common libraries * Add support to run ansible module asynchronously * In devices.AnsibleHostBase, use the improvement of module_ignore_errors by dawnbeauty * Update the platform scripts to use the improved pytest infrastructure * Add a few Mellanox specific testing scripts for completeness and demonstration
Collaborator
Author
|
@lguohan Would you please kindly review this PR? |
jleveque
approved these changes
Aug 20, 2019
2 tasks
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
…submodule head (sonic-net#11761) linkmgrd: * 476f85e 2022-08-17 | Update linkmgr health after getting default route update (sonic-net#117) (HEAD -> 202205, github/202205) [Longxiang Lyu] * fc589e9 2022-08-17 | Use `table` to toggle peer forwarding state (sonic-net#108) (sonic-net#120) [Longxiang Lyu] * bcb5a56 2022-08-17 | Fix azure pipeline (sonic-net#118) (sonic-net#121) [Longxiang Lyu] swss: * ef3a601 2022-08-17 | [muxorch] Returning true if nbr in skip_neighbor_ in isNeighborActive() (sonic-net#2415) (HEAD -> 202205) [Nikola Dancejic] sairedis: * aed01cd 2022-08-12 | Fix: missing sonic-db-cli in docker-sonic-vs image (sonic-net#1072) (sonic-net#1104) (github/202205) [Hua Liu] platform-daemon: * 5a68073 2022-08-01 | Xcvrd changes to support 400G ZR configuration (sonic-net#270) (HEAD -> 202205) [Prince George] swsssdk: * ca785a2 2022-06-01 | Remove sonic-db-cli (sonic-net#122) (HEAD -> 202205, origin/202205) [Hua Liu] Signed-off-by: Ying Xie <[email protected]> Signed-off-by: Ying Xie <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
Improvements:
Type of change
Approach
How did you do it?
Added a
commonsubfolder undersonic-mgmt/teststo hold common library modules. In thesonic-mgmt/tests/common/devices.py, added couple of classes to different devices may be used in testbed. The base class AnsibleHostBase encapsulate the behavior previously defined in ansible_host.py. Some other classes like SonicHost inherit from AnsibleHostBase. The SonicHost class can be extended with more methods for frequently used functions.How did you verify/test it?
Tested on Mellanox platform.
Any platform specific information?
The scripts under
sonic-mgmt/tests/platform/mellanoxare specific for Mellanox platforms.Supported testbed topology if it's a new test case?
The platform scripts support all the current topologies.
Documentation