[action] [PR:10430] [Nvidia] Fix dscp remapping cases#11492
Merged
mssonicbld merged 1 commit intosonic-net:202305from Feb 1, 2024
Merged
[action] [PR:10430] [Nvidia] Fix dscp remapping cases#11492mssonicbld merged 1 commit intosonic-net:202305from
mssonicbld merged 1 commit intosonic-net:202305from
Conversation
* Fix dscp remapping cases 1. fix the lag support logic for dscp remapping test 2. fix a bug introduced by community PR sonic-net#8149
7 tasks
Collaborator
Author
|
Original PR: #10430 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fix 2 issues of the dscp remapping test:
This affects the test case test_xoff_for_pcbb and test_tunnel_decap_dscp_to_pg_mapping
https://github.com/sonic-net/sonic-mgmt/pull/8149/files#diff-c1dbec061026de1f0fe921b088b2596a0a2b31ce337f567d3aadda76521254b0L835-R845
Without the correct values for inner and outer dscp, the test will fail on Nvidia platforms.
Type of change
Back port request
Approach
What is the motivation for this PR?
Fix 2 issues of the dscp remapping test
How did you do it?
For the first issue, when getting the dut port, if there is no key "dst" in interface_to_front_mapping, try to get the port by key "src". Currently the logic is if we use "port_map_file_ini" in the ptf test(which is used by the remapping test), there will be no key "dst" in interface_to_front_mapping.
For the second issue, revert the wrong change.
How did you verify/test it?
Run all cases in test_tunnel_qos_remap.py on 4600c dualtor testbed, all passed.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation