[action] [PR:11244] Reducing the number of packets for WRR and WRR_Change from 500 to 300.#11296
Merged
mssonicbld merged 1 commit intosonic-net:202311from Jan 17, 2024
Merged
Conversation
7 tasks
Collaborator
Author
|
Original PR: #11244 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Both WRR and WRR_Change send packets in bulk(500 packets as of now), and expect all packets back in bulk. When the PTF is not able to handle all packets the tests fail. We have seen this before, and had reduced the packets from 1000 to 500. But in recent MS runs, we observe that the PTF is not handling even the 500 packets. This PR addresses this by reducing the total number of packets to 300.
Summary:
Fixes the test fail issue due to PTF in @XuChen-MSFT 's runs.
Type of change
Back port request
Approach
What is the motivation for this PR?
This PR reduces the total number of packets used by WRR and WRR_change tests. This is to allow the PTF to handle all the packets.
How did you do it?
Updated the qos.yaml parameters.
How did you verify/test it?
Ran the test:
=============================================================================================== PASSES ===============================================================================================
_________________________________________________________________________ TestQosSai.testQosSaiDwrrWeightChange[single_asic] _________________________________________________________________________
----------------------------------------------------------------- generated xml file: /run_logs/logs/qos/tr_2024-01-10-20-58-10.xml ------------------------------------------------------------------
INFO:root:Can not get Allure report URL. Please check logs
--------------------------------------------------------------------------------------- live log sessionfinish ---------------------------------------------------------------------------------------
21:03:51 init.pytest_terminal_summary L0064 INFO | Can not get Allure report URL. Please check logs
====================================================================================== short test summary info =======================================================================================
PASSED qos/test_qos_sai.py::TestQosSai::testQosSaiDwrrWeightChange[single_asic]
SKIPPED [1] /data/tests/qos/qos_sai_base.py:548: Did not find any frontend node that is multi-asic - so can't run single_dut_multi_asic tests
SKIPPED [1] /data/tests/qos/qos_sai_base.py:554: multi-dut is not supported on T1 topologies
=============================================================================== 1 passed, 2 skipped in 340.10 seconds ================================================================================
AzDevOps@99027110b121:/data/tests$
Any platform specific information?
Cisco-8000 only.
Supported testbed topology if it's a new test case?
N/A
Documentation
N/A