Skip to content

Reducing the number of packets for WRR and WRR_Change from 500 to 300.#11244

Merged
kevinskwang merged 1 commit intosonic-net:masterfrom
rraghav-cisco:wrr-reduce-numbers
Jan 17, 2024
Merged

Reducing the number of packets for WRR and WRR_Change from 500 to 300.#11244
kevinskwang merged 1 commit intosonic-net:masterfrom
rraghav-cisco:wrr-reduce-numbers

Conversation

@rraghav-cisco
Copy link
Contributor

Description of PR

Both WRR and WRR_Change send packets in bulk(500 packets as of now), and expect all packets back in bulk. When the PTF is not able to handle all packets the tests fail. We have seen this before, and had reduced the packets from 1000 to 500. But in recent MS runs, we observe that the PTF is not handling even the 500 packets. This PR addresses this by reducing the total number of packets to 300.

Summary:
Fixes the test fail issue due to PTF in @XuChen-MSFT 's runs.

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 201911
  • 202012
  • 202205
  • 202305

Approach

What is the motivation for this PR?

This PR reduces the total number of packets used by WRR and WRR_change tests. This is to allow the PTF to handle all the packets.

How did you do it?

Updated the qos.yaml parameters.

How did you verify/test it?

Ran the test:

=============================================================================================== PASSES ===============================================================================================
_________________________________________________________________________ TestQosSai.testQosSaiDwrrWeightChange[single_asic] _________________________________________________________________________
----------------------------------------------------------------- generated xml file: /run_logs/logs/qos/tr_2024-01-10-20-58-10.xml ------------------------------------------------------------------
INFO:root:Can not get Allure report URL. Please check logs
--------------------------------------------------------------------------------------- live log sessionfinish ---------------------------------------------------------------------------------------
21:03:51 init.pytest_terminal_summary L0064 INFO | Can not get Allure report URL. Please check logs
====================================================================================== short test summary info =======================================================================================
PASSED qos/test_qos_sai.py::TestQosSai::testQosSaiDwrrWeightChange[single_asic]
SKIPPED [1] /data/tests/qos/qos_sai_base.py:548: Did not find any frontend node that is multi-asic - so can't run single_dut_multi_asic tests
SKIPPED [1] /data/tests/qos/qos_sai_base.py:554: multi-dut is not supported on T1 topologies
=============================================================================== 1 passed, 2 skipped in 340.10 seconds ================================================================================
AzDevOps@99027110b121:/data/tests$

Any platform specific information?

Cisco-8000 only.

Supported testbed topology if it's a new test case?

N/A

Documentation

N/A

@rraghav-cisco
Copy link
Contributor Author

@alpeshspatel , @XuChen-MSFT for viz.

Copy link
Contributor

@XuChen-MSFT XuChen-MSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202305: #11295

@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202311: #11296

@XuChen-MSFT
Copy link
Contributor

@rraghav-cisco
according to today's remote debug, do you still need to change packet number for wrr case?
and this PR just changed packet number for gb asic.

@rraghav-cisco
Copy link
Contributor Author

@XuChen-MSFT : No, I don't want to reduce the number of packets. If possible, lets stick with the older numbers.

XuChen-MSFT added a commit to XuChen-MSFT/sonic-mgmt that referenced this pull request Jan 23, 2024
kevinskwang pushed a commit that referenced this pull request Jan 24, 2024
mssonicbld pushed a commit to mssonicbld/sonic-mgmt that referenced this pull request Jan 24, 2024
mssonicbld pushed a commit to mssonicbld/sonic-mgmt that referenced this pull request Jan 24, 2024
mssonicbld pushed a commit that referenced this pull request Jan 24, 2024
mssonicbld pushed a commit that referenced this pull request Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants