[action] [PR:10867] Fix issue with test_syslog_rate_limit#10982
Merged
mssonicbld merged 1 commit intosonic-net:202305from Dec 8, 2023
Merged
[action] [PR:10867] Fix issue with test_syslog_rate_limit#10982mssonicbld merged 1 commit intosonic-net:202305from
mssonicbld merged 1 commit intosonic-net:202305from
Conversation
There is a race condition in the rate-limit-host Changing the rate limit via the cli triggers hostcfgd to restart rsyslogd. However there is no wait to make sure this actually happens. This leads to some flakyness where loganalyzer.py would try to put a marker while the rsyslog systemd service is being restarted and crash.
7 tasks
Collaborator
Author
|
Original PR: #10867 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
There is a race condition in the rate-limit-host test code.
Changing the rate limit via the cli triggers hostcfgd to restart rsyslogd. However there is no wait to make sure this actually happens. This leads to some flakyness where loganalyzer.py would try to put a marker while the rsyslog systemd service is being restarted and crash.
Type of change
Back port request
Approach
What is the motivation for this PR?
Fix flaky test to enhance pass rate reliability.
How did you do it?
Reproduced on my testbed, investigated the issue, fixed the issue
How did you verify/test it?
Stressed the test overnight without further failure