Fix issue with test_syslog_rate_limit#10867
Conversation
|
The pre-commit check detected issues in the files touched by this pull request. Detailed pre-commit check results: To run the pre-commit checks locally, you can follow below steps:
|
There is a race condition in the rate-limit-host Changing the rate limit via the cli triggers hostcfgd to restart rsyslogd. However there is no wait to make sure this actually happens. This leads to some flakyness where loganalyzer.py would try to put a marker while the rsyslog systemd service is being restarted and crash.
fd117f3 to
f0e7f71
Compare
There is a race condition in the rate-limit-host Changing the rate limit via the cli triggers hostcfgd to restart rsyslogd. However there is no wait to make sure this actually happens. This leads to some flakyness where loganalyzer.py would try to put a marker while the rsyslog systemd service is being restarted and crash.
|
Cherry-pick PR to 202305: #10982 |
There is a race condition in the rate-limit-host Changing the rate limit via the cli triggers hostcfgd to restart rsyslogd. However there is no wait to make sure this actually happens. This leads to some flakyness where loganalyzer.py would try to put a marker while the rsyslog systemd service is being restarted and crash.
Description of PR
There is a race condition in the rate-limit-host test code.
Changing the rate limit via the cli triggers hostcfgd to restart rsyslogd. However there is no wait to make sure this actually happens. This leads to some flakyness where loganalyzer.py would try to put a marker while the rsyslog systemd service is being restarted and crash.
Type of change
Back port request
Approach
What is the motivation for this PR?
Fix flaky test to enhance pass rate reliability.
How did you do it?
Reproduced on my testbed, investigated the issue, fixed the issue
How did you verify/test it?
Stressed the test overnight without further failure