Skip to content

[202205] Revert LPM test due to design change back and fix the issue of issue of test_check_sfputil_low_power_mode#10874

Merged
yxieca merged 3 commits intosonic-net:202205from
JibinBao:revert_lpm_202205
Dec 11, 2023
Merged

[202205] Revert LPM test due to design change back and fix the issue of issue of test_check_sfputil_low_power_mode#10874
yxieca merged 3 commits intosonic-net:202205from
JibinBao:revert_lpm_202205

Conversation

@JibinBao
Copy link
Copy Markdown
Contributor

@JibinBao JibinBao commented Nov 29, 2023

Description of PR

Summary:

  1. Revert LPM test, because the implementation has been reverted to the old way.[202205] [Mellanox] Revert LPM implementation to the old way sonic-buildimage#17179
  2. Fix issue of test_check_sfputil_low_power_mode. Previously after setting the lpmode, test checks the value is on or off, which is not correct. we should check if the value of lpmode is the set one.

Fixes # (issue)

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 201911
  • 202012
  • 202205
  • 202305

Approach

What is the motivation for this PR?

Revert lpm test

How did you do it?

Revert lpm test

How did you verify/test it?

Run lmp test on after merging sonic-net/sonic-buildimage#17179

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

When setting lpm, we need to check it is changed to the corresponding mode, not just check lpm is on o off.

Change-Id: I97ac5818d57c4ae15be3dbee7dae4878a95f8b2c
@JibinBao JibinBao closed this Nov 29, 2023
@JibinBao JibinBao reopened this Nov 29, 2023
@JibinBao JibinBao changed the title [202205] Revert lpm test [202205] Revert LPM test due to design change back Nov 30, 2023
@JibinBao JibinBao changed the title [202205] Revert LPM test due to design change back [202205] Revert LPM test due to design change back and fix the issue of issue of test_check_sfputil_low_power_mode Dec 8, 2023
@liat-grozovik
Copy link
Copy Markdown
Collaborator

@yxieca please help to merge to release branch

@yxieca yxieca merged commit ef9c279 into sonic-net:202205 Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants