[202205] [Mellanox] Revert LPM implementation to the old way#17179
Merged
yxieca merged 2 commits intosonic-net:202205from Dec 12, 2023
Merged
[202205] [Mellanox] Revert LPM implementation to the old way#17179yxieca merged 2 commits intosonic-net:202205from
yxieca merged 2 commits intosonic-net:202205from
Conversation
…e toggling LPM (sonic-net#14370)" This reverts commit f74c69e.
Signed-off-by: Kebo Liu <[email protected]>
Junchao-Mellanox
approved these changes
Nov 16, 2023
Collaborator
|
@prgeor please help to review. |
liat-grozovik
approved these changes
Nov 19, 2023
Collaborator
|
@prgeor to check |
Collaborator
Author
|
Hi @yxieca @prgeor this PR intends to backport #17096 to the 202205 branch, the original PR has been merged. The change to 202205 is not exactly the same because of the codebase difference on both branches. This change has also been verified on the 202205 branch, would you please help to review and merge? |
Contributor
|
@prgeor please help check. |
7 tasks
Collaborator
Author
|
@prgeor would you please help to review and approve? this is a backport PR. |
prgeor
approved these changes
Dec 12, 2023
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
backport #17096 because of no clean cherry-pick
The current low power mode setting implementation requests the user to set the port to admin down first before toggling LP mode, this is not backward compatible, now revert it to the old way so that the user can toggle the LP mode regardless of the port admin status.
Work item tracking
How I did it
Reverts commit f74c69e.
How to verify it
run all sfputil and SFP platform API related tests on all the Mellanox platforms.
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)