[warm-reboot] Add lag flap check after warm boot#1066
Merged
neethajohn merged 2 commits intosonic-net:masterfrom Aug 19, 2019
Merged
[warm-reboot] Add lag flap check after warm boot#1066neethajohn merged 2 commits intosonic-net:masterfrom
neethajohn merged 2 commits intosonic-net:masterfrom
Conversation
Signed-off-by: Neetha John <[email protected]>
yxieca
reviewed
Aug 12, 2019
| if 'interfaces' in obj and 'Port-Channel1' in obj['interfaces']: | ||
| intf_cnt_info = obj['interfaces']['Port-Channel1']['interfaceCounters'] | ||
| flap_cnt = intf_cnt_info['linkStatusChanges'] | ||
| is_flap = (flap_cnt != 0) |
Collaborator
There was a problem hiding this comment.
I don't feel that having is_flap is absolutely necessary. Caller can deduce this information from flap_count since the assumption is that the counter is reset at the beginning of the test.
yxieca
approved these changes
Aug 13, 2019
yxieca
pushed a commit
that referenced
this pull request
Aug 19, 2019
* Add lag flap check after warm boot Signed-off-by: Neetha John <[email protected]>
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
Submodule src/sonic-swss 0e5c1ff..fcd091c: > [mirrororch]: Remove mirror session state after it is remvoed (sonic-net#1066) Submodule src/sonic-utilities a89b9d4..54946e9: > [acl_loader]: Add monitor port column in show mirror_session output (sonic-net#662) > [warm/fast reboot] some service docker might have been stopped already (sonic-net#668) Signed-off-by: Ying Xie <[email protected]>
Pterosaur
pushed a commit
to Pterosaur/sonic-mgmt
that referenced
this pull request
Mar 25, 2026
…net#1066) <!-- Please make sure you've read and understood our contributing guidelines; https://github.com/sonic-net/SONiC/blob/gh-pages/CONTRIBUTING.md Please provide following information to help code review process a bit easier: --> ### Description of PR <!-- - Please include a summary of the change and which issue is fixed. - Please also include relevant motivation and context. Where should reviewer start? background context? - List any dependencies that are required for this change. --> Summary: Fixes sonic-net#20729 ### Type of change <!-- - Fill x for your type of change. - e.g. - [x] Bug fix --> - [x] Bug fix - [ ] Testbed and Framework(new/improvement) - [ ] New Test case - [ ] Skipped for non-supported platforms - [ ] Test case improvement ### Back port request - [ ] 202205 - [ ] 202305 - [ ] 202311 - [ ] 202405 - [x] 202411 - [x] 202505 - [x] 202511 ### Approach #### What is the motivation for this PR? Enable test_po_update with ipv6-only topo #### How did you do it? Added steps for ipv6 #### How did you verify/test it? Ran on ipv6-only topo testbed <img width="2964" height="400" alt="image" src="https://github.com/user-attachments/assets/1ba5af3a-8a5f-4eab-8180-9eb96329cb6a" /> #### Any platform specific information? #### Supported testbed topology if it's a new test case? ### Documentation <!-- (If it's a new feature, new test case) Did you update documentation/Wiki relevant to your implementation? Link to the wiki page? --> Signed-off-by: Sonic Build Admin <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Neetha John [email protected]
Description of PR
Verify that no LAG flaps are seen on the neighbors after warm-reboot
Type of change
Approach
How did you do it?
Clear interface counters on the neighbors prior to warm boot
Verify that 'linkStatusChanges' counter on the neighbors after warm boot is still 0
How did you verify/test it?
Image with issue:
"2019-08-09 17:45:33 : ",
"2019-08-09 17:45:35 : No LAG flaps seen on 10.64.247.207 after warm boot",
"2019-08-09 17:45:37 : No LAG flaps seen on 10.64.247.206 after warm boot",
"2019-08-09 17:45:40 : No LAG flaps seen on 10.64.247.204 after warm boot",
"2019-08-09 17:45:40 : ==================================================",
"2019-08-09 17:45:40 : Report:",
"2019-08-09 17:45:40 : ==================================================",
"2019-08-09 17:45:40 : LACP/BGP were down for (extracted from cli):",
"2019-08-09 17:45:40 : --------------------------------------------------",
"2019-08-09 17:45:40 : 10.64.247.204 - lacp: 0.000 (0) po_events: (1) bgp v4: 0.000 (0) bgp v6: 0.000 (0)",
"2019-08-09 17:45:40 : 10.64.247.205 - lacp: 0.000 (0) po_events: (1) bgp v4: 0.000 (0) bgp FAIL",
"",
"======================================================================",
"FAIL: advanced-reboot.ReloadTest",
"----------------------------------------------------------------------",
"Traceback (most recent call last):",
" File "ptftests/advanced-reboot.py", line 869, in runTest",
" self.assertTrue(is_good, errors)",
"AssertionError: ",
"",
"Something went wrong. Please check output below:",
"",
"FAILED:10.64.247.205:LAG flapped 2 times on 10.64.247.205 after warm boot"
"----------------------------------------------------------------------",
"Ran 1 test in 643.229s",
"",
"FAILED (failures=1)",
Image with fix:
"2019-08-12 10:46:05 : No LAG flaps seen on 10.64.247.207 after warm boot",
"2019-08-12 10:46:07 : No LAG flaps seen on 10.64.247.206 after warm boot",
"2019-08-12 10:46:08 : No LAG flaps seen on 10.64.247.205 after warm boot",
"2019-08-12 10:46:10 : No LAG flaps seen on 10.64.247.204 after warm boot",
"2019-08-12 10:46:10 : ==================================================",
"2019-08-12 10:46:10 : Report:",
"2019-08-12 10:46:10 : ==================================================",
"2019-08-12 10:46:10 : LACP/BGP were down for (extracted from cli):",
"2019-08-12 10:46:10 : --------------------------------------------------",
"2019-08-12 10:46:10 : 10.64.247.204 - lacp: 0.000 (0) po_events: (1) bgp v4: 0.000 (0) bgp v6: 0.000 (0)",
"2019-08-12 10:46:10 : 10.64.247.205 - lacp: 0.000 (0) po_events: (1) bgp v4: 0.000 (0) bgp v6: 0.000 (0)",
"2019-08-12 10:46:10 : 10.64.247.206 - lacp: 0.000 (0) po_events: (1) bgp v4: 0.000 (0) bgp v6: 0.000 (0)",
"2019-08-12 10:46:10 : 10.64.247.207 - lacp: 0.000 (0) po_events: (1) bgp v4: 0.000 (0) bgp v6: 0.000 (0)",
"2019-08-12 10:46:10 : --------------------------------------------------",
"2019-08-12 10:46:10 : Extracted from VM logs:",
"2019-08-12 10:46:10 : -----------------------ok",
"",
"----------------------------------------------------------------------",
"Ran 1 test in 667.161s",
"",
"OK",
"---------------------------",