Skip to content

Fix test_route_perf#3524

Merged
bingwang-ms merged 1 commit intosonic-net:masterfrom
bingwang-ms:fix_test_route_perf_2
May 25, 2021
Merged

Fix test_route_perf#3524
bingwang-ms merged 1 commit intosonic-net:masterfrom
bingwang-ms:fix_test_route_perf_2

Conversation

@bingwang-ms
Copy link
Copy Markdown
Collaborator

Description of PR

Summary:
This PR is to fix test_route_perf.

Test case test_route_perf failed on some platform (Like SN4600) because the added nexthop is a member of PortChannel.
orchagent will crash with following errors.

May 24 12:53:13.138090 str-msn4600c-acs-02 ERR syncd#SDK: [SAI_UTILS.ERR] mlnx_sai_utils.c[858]- check_port_type_attr: Port LAG member object id 16b0000000001 is not supported by attr id 2
May 24 12:53:13.138121 str-msn4600c-acs-02 ERR syncd#SDK: :- sendApiResponse: api SAI_COMMON_API_CREATE failed in syncd mode: SAI_STATUS_INVALID_PORT_NUMBER
May 24 12:53:13.138441 str-msn4600c-acs-02 ERR syncd#SDK: :- processQuadEvent: attr: SAI_ROUTER_INTERFACE_ATTR_VIRTUAL_ROUTER_ID: oid:0x3000000000010
May 24 12:53:13.138441 str-msn4600c-acs-02 ERR syncd#SDK: :- processQuadEvent: attr: SAI_ROUTER_INTERFACE_ATTR_SRC_MAC_ADDRESS: 1C:34:DA:1D:E4:00
May 24 12:53:13.138470 str-msn4600c-acs-02 ERR syncd#SDK: :- processQuadEvent: attr: SAI_ROUTER_INTERFACE_ATTR_TYPE: SAI_ROUTER_INTERFACE_TYPE_PORT
May 24 12:53:13.138470 str-msn4600c-acs-02 ERR syncd#SDK: :- processQuadEvent: attr: SAI_ROUTER_INTERFACE_ATTR_PORT_ID: oid:0x100000000095f
May 24 12:53:13.138491 str-msn4600c-acs-02 ERR syncd#SDK: :- processQuadEvent: attr: SAI_ROUTER_INTERFACE_ATTR_MTU: 9100
May 24 12:53:13.138667 str-msn4600c-acs-02 ERR swss#orchagent: :- create: create status: SAI_STATUS_INVALID_PORT_NUMBER
May 24 12:53:13.138667 str-msn4600c-acs-02 ERR swss#orchagent: :- addRouterIntfs: Failed to create router interface Ethernet8, rv:-9
May 24 12:53:13.139181 str-msn4600c-acs-02 INFO swss#/supervisord: orchagent terminate called after throwing an instance of 'std::runtime_error'
May 24 12:53:13.139181 str-msn4600c-acs-02 INFO swss#/supervisord: orchagent   what():  Failed to create router interface.

This PR fixes the issue by skipping interfaces that are already in PortChannels.

Signed-off-by: bingwang bingwang@microsoft.com

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Approach

What is the motivation for this PR?

This PR is to fix test_route_perf.

How did you do it?

This PR fixes the issue by skipping interfaces that are already in PortChannels.

How did you verify/test it?

Verified on SN4600, both T0 and T1 testbeds. All test case passed.

Any platform specific information?

No.

Supported testbed topology if it's a new test case?

No.

Documentation

Signed-off-by: bingwang <bingwang@microsoft.com>
@bingwang-ms bingwang-ms requested a review from shi-su May 24, 2021 12:57
@bingwang-ms bingwang-ms requested a review from a team as a code owner May 24, 2021 12:57
@bingwang-ms
Copy link
Copy Markdown
Collaborator Author

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@bingwang-ms bingwang-ms merged commit 01a23a8 into sonic-net:master May 25, 2021
vmittal-msft pushed a commit to vmittal-msft/sonic-mgmt that referenced this pull request Sep 28, 2021
Signed-off-by: bingwang <bingwang@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants