Skip to content

Added conditional check for ptf32 and ptf64 topo in snmp.yml file#1064

Closed
rajneeshaec wants to merge 1 commit intosonic-net:masterfrom
rajneeshaec:sonic-mgmt-marvell_snmp
Closed

Added conditional check for ptf32 and ptf64 topo in snmp.yml file#1064
rajneeshaec wants to merge 1 commit intosonic-net:masterfrom
rajneeshaec:sonic-mgmt-marvell_snmp

Conversation

@rajneeshaec
Copy link
Contributor

@rajneeshaec rajneeshaec commented Aug 12, 2019

Description of PR

snmp.yml

  • snmp lldp test case is failing with ptf32 topology
  • ptf32 and ptf64 topology is not using the arista-veos VM's.That's why this test case is
    not valid for ptf32/64 topology.Test-case will fail For remote values check.
  • sonic DUT is not returning any lldp data with Ptf32/64 topology
  • Added condition to check the testbed_type != ptf32 and ptf64

Summary:
Fixes # (issue)

Type of change

  • [-/] Bug fix
  • [] Testbed and Framework(new/improvement)
  • [] Test case(new/improvement)

Approach

How did you do it?

Added conditional check in roles/test/tasks/snmp.yml file

How did you verify/test it?

tested in local testbed

Any platform specific information?

N/A

Supported testbed topology if it's a new test case?

N/A

Documentation

N/A

Copy link
Contributor

@stcheng stcheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you need to change the environment for a test case, please update the file: roles/test/vars/testcases.yml

@rajneeshaec
Copy link
Contributor Author

If you need to change the environment for a test case, please update the file: roles/test/vars/testcases.yml

Task - name: include snmp lldp test is failing with ptf-32 and ptf-64 topologies
other snmp tasks present in snmp.yml playbook file is valid for both ptf-32 and ptf-64 topologies
I dont't know how to fix this issue using testcases.yml file
Could you please help me to fix this issue

@avi-milner
Copy link

If you need to change the environment for a test case, please update the file: roles/test/vars/testcases.yml

this is a specific

If you need to change the environment for a test case, please update the file: roles/test/vars/testcases.yml

the change is only for a specific test within the snmp,yml playbook that is not supporteed - can't be handle by roles/test/vars/testcases.yml but needs to be handled within playbook with a conditional include

@gord1306
Copy link
Contributor

gord1306 commented Sep 7, 2019

PR #1054 is also fixed the same issue

@rajneeshaec rajneeshaec requested a review from stcheng October 16, 2019 07:15
@lguohan
Copy link
Contributor

lguohan commented Mar 20, 2020

deprecated as implementation is in pytest now.

@lguohan lguohan closed this Mar 20, 2020
Pterosaur pushed a commit to Pterosaur/sonic-mgmt that referenced this pull request Mar 25, 2026
…onic-net#1064)

<!--
Please make sure you've read and understood our contributing guidelines;
https://github.com/sonic-net/SONiC/blob/gh-pages/CONTRIBUTING.md

Please provide following information to help code review process a bit easier:
-->
### Description of PR
Remove xfail because the test can pass on v6 topos after garp fix:
sonic-net#21155
<!--
- Please include a summary of the change and which issue is fixed.
- Please also include relevant motivation and context. Where should reviewer start? background context?
- List any dependencies that are required for this change.
-->

Summary:
Fixes # (issue)

### Type of change

<!--
- Fill x for your type of change.
- e.g.
- [x] Bug fix
-->

- [ ] Bug fix
- [ ] Testbed and Framework(new/improvement)
- [ ] New Test case
 - [ ] Skipped for non-supported platforms
- [x] Test case improvement

### Back port request
- [x] 202412
- [x] 202505

### Approach
#### What is the motivation for this PR?
The test case can pass with the fix from sonic-net#21155

#### How did you do it?
Remove xfail in tests_mark_conditions.yaml

#### How did you verify/test it?
The test passed on v6 topo after removing xfail

#### Any platform specific information?

#### Supported testbed topology if it's a new test case?
v6 topos

### Documentation
<!--
(If it's a new feature, new test case)
Did you update documentation/Wiki relevant to your implementation?
Link to the wiki page?
-->

Signed-off-by: Sonic Build Admin <sonicbld@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants