Added conditional check for ptf32 and ptf64 topo in snmp.yml file#1064
Added conditional check for ptf32 and ptf64 topo in snmp.yml file#1064rajneeshaec wants to merge 1 commit intosonic-net:masterfrom
Conversation
stcheng
left a comment
There was a problem hiding this comment.
If you need to change the environment for a test case, please update the file: roles/test/vars/testcases.yml
Task - name: include snmp lldp test is failing with ptf-32 and ptf-64 topologies |
this is a specific
the change is only for a specific test within the snmp,yml playbook that is not supporteed - can't be handle by roles/test/vars/testcases.yml but needs to be handled within playbook with a conditional include |
|
PR #1054 is also fixed the same issue |
|
deprecated as implementation is in pytest now. |
…onic-net#1064) <!-- Please make sure you've read and understood our contributing guidelines; https://github.com/sonic-net/SONiC/blob/gh-pages/CONTRIBUTING.md Please provide following information to help code review process a bit easier: --> ### Description of PR Remove xfail because the test can pass on v6 topos after garp fix: sonic-net#21155 <!-- - Please include a summary of the change and which issue is fixed. - Please also include relevant motivation and context. Where should reviewer start? background context? - List any dependencies that are required for this change. --> Summary: Fixes # (issue) ### Type of change <!-- - Fill x for your type of change. - e.g. - [x] Bug fix --> - [ ] Bug fix - [ ] Testbed and Framework(new/improvement) - [ ] New Test case - [ ] Skipped for non-supported platforms - [x] Test case improvement ### Back port request - [x] 202412 - [x] 202505 ### Approach #### What is the motivation for this PR? The test case can pass with the fix from sonic-net#21155 #### How did you do it? Remove xfail in tests_mark_conditions.yaml #### How did you verify/test it? The test passed on v6 topo after removing xfail #### Any platform specific information? #### Supported testbed topology if it's a new test case? v6 topos ### Documentation <!-- (If it's a new feature, new test case) Did you update documentation/Wiki relevant to your implementation? Link to the wiki page? --> Signed-off-by: Sonic Build Admin <sonicbld@microsoft.com>
Description of PR
snmp.yml
not valid for ptf32/64 topology.Test-case will fail For remote values check.
Summary:
Fixes # (issue)
Type of change
Approach
How did you do it?
Added conditional check in roles/test/tasks/snmp.yml file
How did you verify/test it?
tested in local testbed
Any platform specific information?
N/A
Supported testbed topology if it's a new test case?
N/A
Documentation
N/A