Removed hard-coded value from docker.py#106
Merged
qiluo-msft merged 2 commits intosonic-net:masterfrom Feb 24, 2017
Merged
Conversation
Signed-off-by: Pavlo Kandrin <[email protected]>
Contributor
|
@qiluo-msft, can you take a look at this? |
qiluo-msft
requested changes
Feb 3, 2017
ansible/shell_plugins/docker.py
Outdated
| ## find the temporary directories Ansible created on remote machine. So we | ||
| ## collect them and copied to docker container in build_module_command | ||
| if len(args) >= 2 and args[0].startswith('/home/') and args[1] == '': | ||
| if len(args) >= 2 and args[1] == '': |
Contributor
There was a problem hiding this comment.
Is it true that you customize the home directory on 'some systems'? If yes, instead of removing the condition, could you find the accurate "home" directory and keep the condition?
Contributor
Author
There was a problem hiding this comment.
I'm trying to deploy on the system with only root user. The "home" directory for root user is "/root/" so this condition always fails. I'll update this pull request today to keep condition for root user too.
Contributor
|
can you explain what failure you have experienced? |
qiluo-msft
approved these changes
Feb 11, 2017
lguohan
pushed a commit
that referenced
this pull request
Aug 3, 2017
* Fix failure of deployment on docker container. Verified on HW as well. Signed-off-by: Pavlo Kandrin <[email protected]> * Added root user's home directory to condition for collecting temporary directories
nhe-NV
pushed a commit
to nhe-NV/sonic-mgmt
that referenced
this pull request
May 12, 2025
…nly topology deployable (sonic-net#106) <!-- Please make sure you've read and understood our contributing guidelines; https://github.com/sonic-net/SONiC/blob/gh-pages/CONTRIBUTING.md Please provide following information to help code review process a bit easier: --> ### Description of PR <!-- - Please include a summary of the change and which issue is fixed. - Please also include relevant motivation and context. Where should reviewer start? background context? - List any dependencies that are required for this change. --> Summary: Fixes # (issue) We have ipv6 address only topology which only establish ipv6 BGP sessions. So we raise this PR to make ipv4 BGP sessions optional and make ipv6 only topology deployable. ### Type of change <!-- - Fill x for your type of change. - e.g. - [x] Bug fix --> - [ ] Bug fix - [x] Testbed and Framework(new/improvement) - [ ] Test case(new/improvement) ### Back port request - [ ] 202012 - [ ] 202205 - [ ] 202305 - [ ] 202311 - [ ] 202405 ### Approach #### What is the motivation for this PR? We have ipv6 address only topology which only establish ipv6 BGP sessions. #### How did you do it? Make ipv4 BGP sessions optional and make ipv6 only topology deployable #### How did you verify/test it? Deploy in lab #### Any platform specific information? #### Supported testbed topology if it's a new test case? ### Documentation <!-- (If it's a new feature, new test case) Did you update documentation/Wiki relevant to your implementation? Link to the wiki page? -->
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
This PR updates the following commits in sonic-platform-common 6ad0004 [component] add auto_update_firmware() to support the auto update. (sonic-net#106) 49076a9 [sonic_y_cable] Add support for measuring BER and EYE scan and running Loopback, PRBS modes on the Y cable (sonic-net#158) 6b12b4c [sfp] Add parsing the dom_capability to sff8472 (sonic-net#102) 7fc76b9 [sonic_pcie] Add get_pcie_aer_stats and its common implementation (sonic-net#144) Signed-off-by: vaibhav-dahiya <[email protected]>
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
fc5d424 Jing Zhang Fri Aug 12 14:39:59 2022 -0700 [202012] Cherry-pick flaky unit test fixes (sonic-net#115) faceb93 Jing Zhang Thu Aug 11 10:03:05 2022 -0700 Backoff mux probing for server down scenario (sonic-net#106) 86ddd95 Jing Zhang Fri Aug 12 14:21:37 2022 -0700 Fix race condition caused by strand wrap method (sonic-net#104) (sonic-net#110) f68a03e Jing Zhang Thu Aug 11 15:31:22 2022 -0700 [lgtm]: add uuid-dev to lgtm prepare (sonic-net#112) sign-off: Jing Zhang [email protected]
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
…atically (sonic-net#14944) #### Why I did it src/sonic-telemetry ``` * 6dc4bb9 - (HEAD -> 202012, origin/202012) Merge pull request sonic-net#107 from zbud-msft/backport-202012 (33 hours ago) [Tomek Madejski] * cbb7b1e - Update azp yml to generalize branch names (sonic-net#106) (7 days ago) [Zain Budhwani] ```
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
…submodule head (sonic-net#11705) Kernel: * 86c4b66 2022-07-28 | [Mellanox] Add new kernel patches from HW-MGMT package V.7.0020.3005 (sonic-net#287) (HEAD -> 202205) [Kebo Liu] * 3a8416a 2022-07-05 | [patch] mlxsw: i2c: Prevent transaction execution for special chip (sonic-net#279) [Stepan Blyshchak] swss: * 3f69944 2022-08-10 | Set internal class state to reflect the actual state (sonic-net#2410) (HEAD -> 202205, tag: foo) [Prince Sunny] * 87e98eb 2022-08-09 | [portsorch] Expose supported FEC modes to STABE_DB and check whether FEC mode is supported before setting it (sonic-net#2400) [Stephen Sun] * e71ab99 2022-07-29 | portsorch: initial support for link-training (sonic-net#2359) [Dante (Kuo-Jung) Su] * ed5e5be 2022-07-08 | Port configuration incremental update support (sonic-net#2305) [Junchao-Mellanox] utilities: * 0df3ba8 2022-08-12 | Revert "Improve the way to check port type of RJ45 port (sonic-net#2249)" (HEAD -> 202205) [Ying Xie] * 9b21903 2022-08-12 | Fix test failure in dump table test in 202205 (sonic-net#2307) (HEAD -> 202205, github/202205) [Stephen Sun] * 750d1db 2022-08-11 | Convert IPv6 addresses to lowercase in apply-patch (sonic-net#2299) (HEAD -> 202205) [dbarashinvd] * 555947e 2022-08-09 | [config][muxcable] add support to enable/disable ycable telemetry (sonic-net#2297) [vdahiya12] * 978f416 2022-08-09 | Fix GCU bug when backend service modifying config (sonic-net#2295) [jingwenxie] * 8fed381 2022-08-02 | [intfutil] Check whether the FEC mode is supported on the platform before configuring it to CONFIG_DB (sonic-net#2223) (github/202205) [Stephen Sun] * a1a09e4 2022-07-29 | Improve the way to check port type of RJ45 port (sonic-net#2249) [Stephen Sun] * 9bdbfb8 2022-05-19 | sonic-utils: initial support for link-training (sonic-net#2071) [Dante (Kuo-Jung) Su] * c088ec4 2022-08-10 | Support to enable fips for the command sonic_installer (sonic-net#2154) (sonic-net#2303) [xumia] platform-daemon: * 767cfb6 2022-08-09 | [ycabled] add capability to enable/disable telemetry (sonic-net#279) (HEAD -> 202205) [vdahiya12] linkmgrd: * cf1ba2b 2022-08-12 | wait for handler to be completed (sonic-net#114) (HEAD -> 202205, github/202205) [Jing Zhang] * e99026c 2022-08-11 | [lgtm]: add uuid-dev to lgtm prepare (sonic-net#112) (HEAD -> 202205) [Jing Zhang] * bd1b7f0 2022-08-11 | Adjust `DbInterfaceRaceConditionCheck` to Wait Longer for Handlers to be executed (sonic-net#111) (HEAD -> 202205, github/202205) [Jing Zhang] * e9dc6b2 2022-08-11 | Backoff mux probing for server down scenario (sonic-net#106) [Jing Zhang] * 0d61171 2022-08-09 | Fix race condition caused by strand `wrap` method (sonic-net#104) [Jing Zhang] * e9ede7d 2022-07-02 | Enforce switch after config mux to active (sonic-net#95) [Longxiang Lyu] * 15dbc30 2022-06-30 | Add unittest to verify mux toggle active (sonic-net#94) [Longxiang Lyu] Signed-off-by: Ying Xie <[email protected]>
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
c3d9d8f2bcd364dc81cd4d9bec02666cef648b10 (HEAD -> 201911, origin/201911) API for getting all members from all VLANs (sonic-net#106) Signed-off-by: Abhishek Dosi <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hard-coded '/home/' is a cause of failure on some systems.
Signed-off-by: Pavlo Kandrin [email protected]