[action] [PR:10229] Fix mux-simulator script not starting due to Werkzeug update#10288
Merged
mssonicbld merged 1 commit intosonic-net:202012from Oct 11, 2023
Merged
Conversation
…et#10229) Starting on/around September 29th, the mux-simulator script on the host server failed to start. This is because both the Flask and Werkzeug python packages updated to version 3.0.0 on that day, and there were breaking changes in Werkzeug 3.0.0. Our yaml script installs a fixed Flask version of 2.0.3, and the dependency list for that package only specified "Werkzeug >= 2.0". This means that pip will happily install version 3.0.0 even though it is incompatible with this version of Flask. As a fix, install specifically Flask 2.3.3 and Werkzeug 2.3.7. In addtion, to make it easier to notice failures here, check to see that the systemd service is actually running after it gets started. Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
6 tasks
Collaborator
Author
|
Original PR: #10229 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
Starting on/around September 29th, the mux-simulator script on the host server failed to start. This is because both the Flask and Werkzeug python packages updated to version 3.0.0 on that day, and there were breaking changes in Werkzeug 3.0.0. Our yaml script installs a fixed Flask version of 2.0.3, and the dependency list for that package only specified "Werkzeug >= 2.0". This means that pip will happily install version 3.0.0 even though it is incompatible with this version of Flask.
How did you do it?
As a fix, install specifically Flask 2.3.3 and Werkzeug 2.3.7. In addtion, to make it easier to notice failures here, check to see that the systemd service is actually running after it gets started.
How did you verify/test it?
Tested locally with dualtor KVM
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation