Fix mux-simulator script not starting due to Werkzeug update#10229
Merged
yxieca merged 1 commit intosonic-net:masterfrom Oct 4, 2023
Merged
Fix mux-simulator script not starting due to Werkzeug update#10229yxieca merged 1 commit intosonic-net:masterfrom
yxieca merged 1 commit intosonic-net:masterfrom
Conversation
Starting on/around September 29th, the mux-simulator script on the host server failed to start. This is because both the Flask and Werkzeug python packages updated to version 3.0.0 on that day, and there were breaking changes in Werkzeug 3.0.0. Our yaml script installs a fixed Flask version of 2.0.3, and the dependency list for that package only specified "Werkzeug >= 2.0". This means that pip will happily install version 3.0.0 even though it is incompatible with this version of Flask. As a fix, install specifically Flask 2.3.3 and Werkzeug 2.3.7. In addtion, to make it easier to notice failures here, check to see that the systemd service is actually running after it gets started. Signed-off-by: Saikrishna Arcot <[email protected]>
saiarcot895
force-pushed
the
pin-werkzeug-version
branch
from
81aabff to
486030a
Compare
zjswhhh
approved these changes
Oct 4, 2023
Contributor
zjswhhh
left a comment
zjswhhh
left a comment
There was a problem hiding this comment.
Discussed offline. lgtm.
yxieca
approved these changes
Oct 4, 2023
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Oct 4, 2023
…et#10229) Starting on/around September 29th, the mux-simulator script on the host server failed to start. This is because both the Flask and Werkzeug python packages updated to version 3.0.0 on that day, and there were breaking changes in Werkzeug 3.0.0. Our yaml script installs a fixed Flask version of 2.0.3, and the dependency list for that package only specified "Werkzeug >= 2.0". This means that pip will happily install version 3.0.0 even though it is incompatible with this version of Flask. As a fix, install specifically Flask 2.3.3 and Werkzeug 2.3.7. In addtion, to make it easier to notice failures here, check to see that the systemd service is actually running after it gets started. Signed-off-by: Saikrishna Arcot <[email protected]>
Collaborator
|
Cherry-pick PR to 202205: #10231 |
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Oct 4, 2023
…et#10229) Starting on/around September 29th, the mux-simulator script on the host server failed to start. This is because both the Flask and Werkzeug python packages updated to version 3.0.0 on that day, and there were breaking changes in Werkzeug 3.0.0. Our yaml script installs a fixed Flask version of 2.0.3, and the dependency list for that package only specified "Werkzeug >= 2.0". This means that pip will happily install version 3.0.0 even though it is incompatible with this version of Flask. As a fix, install specifically Flask 2.3.3 and Werkzeug 2.3.7. In addtion, to make it easier to notice failures here, check to see that the systemd service is actually running after it gets started. Signed-off-by: Saikrishna Arcot <[email protected]>
Collaborator
|
Cherry-pick PR to 202305: #10232 |
This was referenced Oct 4, 2023
yxieca
pushed a commit
that referenced
this pull request
Oct 5, 2023
…#10231) Starting on/around September 29th, the mux-simulator script on the host server failed to start. This is because both the Flask and Werkzeug python packages updated to version 3.0.0 on that day, and there were breaking changes in Werkzeug 3.0.0. Our yaml script installs a fixed Flask version of 2.0.3, and the dependency list for that package only specified "Werkzeug >= 2.0". This means that pip will happily install version 3.0.0 even though it is incompatible with this version of Flask. As a fix, install specifically Flask 2.3.3 and Werkzeug 2.3.7. In addtion, to make it easier to notice failures here, check to see that the systemd service is actually running after it gets started. Signed-off-by: Saikrishna Arcot <[email protected]> Co-authored-by: Saikrishna Arcot <[email protected]>
mssonicbld
added
Included in 202205 branch
and removed
Created PR to 202205 branch
labels
yxieca
pushed a commit
that referenced
this pull request
Oct 5, 2023
…#10232) Starting on/around September 29th, the mux-simulator script on the host server failed to start. This is because both the Flask and Werkzeug python packages updated to version 3.0.0 on that day, and there were breaking changes in Werkzeug 3.0.0. Our yaml script installs a fixed Flask version of 2.0.3, and the dependency list for that package only specified "Werkzeug >= 2.0". This means that pip will happily install version 3.0.0 even though it is incompatible with this version of Flask. As a fix, install specifically Flask 2.3.3 and Werkzeug 2.3.7. In addtion, to make it easier to notice failures here, check to see that the systemd service is actually running after it gets started. Signed-off-by: Saikrishna Arcot <[email protected]> Co-authored-by: Saikrishna Arcot <[email protected]>
mssonicbld
added
Included in 202305 branch
and removed
Created PR to 202305 branch
labels
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Oct 11, 2023
…et#10229) Starting on/around September 29th, the mux-simulator script on the host server failed to start. This is because both the Flask and Werkzeug python packages updated to version 3.0.0 on that day, and there were breaking changes in Werkzeug 3.0.0. Our yaml script installs a fixed Flask version of 2.0.3, and the dependency list for that package only specified "Werkzeug >= 2.0". This means that pip will happily install version 3.0.0 even though it is incompatible with this version of Flask. As a fix, install specifically Flask 2.3.3 and Werkzeug 2.3.7. In addtion, to make it easier to notice failures here, check to see that the systemd service is actually running after it gets started. Signed-off-by: Saikrishna Arcot <[email protected]>
Collaborator
|
Cherry-pick PR to 202012: #10288 |
6 tasks
Collaborator
|
Some 202012 failed on dualtor, https://elastictest.org/scheduler/testplan/65250d4c9ac7ee1734c7dd32?testcase=test_pretest.py%7C%7C%7C0&type=console Should be missing the packages, cherry-picking this commit to 202012 |
mssonicbld
pushed a commit
that referenced
this pull request
Oct 11, 2023
Starting on/around September 29th, the mux-simulator script on the host server failed to start. This is because both the Flask and Werkzeug python packages updated to version 3.0.0 on that day, and there were breaking changes in Werkzeug 3.0.0. Our yaml script installs a fixed Flask version of 2.0.3, and the dependency list for that package only specified "Werkzeug >= 2.0". This means that pip will happily install version 3.0.0 even though it is incompatible with this version of Flask. As a fix, install specifically Flask 2.3.3 and Werkzeug 2.3.7. In addtion, to make it easier to notice failures here, check to see that the systemd service is actually running after it gets started. Signed-off-by: Saikrishna Arcot <[email protected]>
mssonicbld
added
Included in 202012 branch
and removed
Created PR to 202012 branch
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
Starting on/around September 29th, the mux-simulator script on the host server failed to start. This is because both the Flask and Werkzeug python packages updated to version 3.0.0 on that day, and there were breaking changes in Werkzeug 3.0.0. Our yaml script installs a fixed Flask version of 2.0.3, and the dependency list for that package only specified "Werkzeug >= 2.0". This means that pip will happily install version 3.0.0 even though it is incompatible with this version of Flask.
How did you do it?
As a fix, install specifically Flask 2.3.3 and Werkzeug 2.3.7. In addtion, to make it easier to notice failures here, check to see that the systemd service is actually running after it gets started.
How did you verify/test it?
Tested locally with dualtor KVM
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation