Skip to content

[Kernel] support downloading built kernel Debian packages#51

Merged
yxieca merged 2 commits intosonic-net:masterfrom
yxieca:download
Jul 25, 2018
Merged

[Kernel] support downloading built kernel Debian packages#51
yxieca merged 2 commits intosonic-net:masterfrom
yxieca:download

Conversation

@yxieca
Copy link
Collaborator

@yxieca yxieca commented Jul 2, 2018

Add support to download pre-built Linux kernel Debian packages instead of building from source files.

This change prefers the method of download over build.

Signed-off-by: Ying Xie [email protected]

Note: this PR is better go in after sonic-net/sonic-buildimage#1837 but it doesn't have to.

@yxieca yxieca requested a review from lguohan July 2, 2018 19:01
Makefile Outdated
.ONESHELL:
SHELL = /bin/bash

ifneq ($(kernel_build_method), "build")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does one set kernel_build_method? Should this become a command-line parameter specified in rules/config?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is. Please take a look at the linked PR.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aha. Sorry, missed the linked PR.

A small concern is the terminology might not be intuitive (i.e., that one of the "build methods" is "download" which doesn't actually build anything). I think a name like "kernel_procure_method" is more accurate. Maybe someone else has another suggestion?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

procure is good. Thanks.

@yxieca yxieca merged commit 61923df into sonic-net:master Jul 25, 2018
dgsudharsan pushed a commit to dgsudharsan/sonic-linux-kernel that referenced this pull request Dec 16, 2025
Backport torvalds/linux@8fbe4c4 into sonic kernel.

On one of our platforms, we sporadically seeing this kernel error log after a reboot

```
2025 Jul 8 15:05:16.109392 sonic ERR kernel: [ 0.121956] efi: memattr: Failed to map EFI Memory Attributes table @ 0xb4ad7118
```

This error log is hard to reproduce, has no functional impact and is also seen in upstream devices as explained the description above. However, the RC of why this is happening is still unknown.

Thus backporting this commit to print more info and change the verbosity to WARN
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants