[make] introducing new build option KERNEL_PROCURE_METHOD#1837
Merged
yxieca merged 3 commits intosonic-net:masterfrom Jul 25, 2018
Merged
[make] introducing new build option KERNEL_PROCURE_METHOD#1837yxieca merged 3 commits intosonic-net:masterfrom
yxieca merged 3 commits intosonic-net:masterfrom
Conversation
- Kernel could be built from source files with method 'build' - Kernel could be downloaded from Azure storage with method 'download' Signed-off-by: Ying Xie <[email protected]>
jleveque
reviewed
Jul 2, 2018
Makefile
Outdated
| # * SOURCE_FOLDER: host path to be mount as /var/$(USER)/src, only effective when KEEP_SLAVE_ON=yes | ||
| # * SONIC_BUILD_JOB: Specifying number of concurrent build job(s) to run | ||
| # * SONIC_BUILD_JOBS: Specifying number of concurrent build job(s) to run | ||
| # * KERNEL_BUILD_METHOD: Specifying method of building kernel: download or build |
Contributor
There was a problem hiding this comment.
Same small concern I raised on the linked PR in sonic-linux-kernel: The terminology might not be intuitive (i.e., that one of the "build methods" is "download" which doesn't actually build anything). I think a name like "KERNEL_PROCURE_METHOD" is more accurate. Maybe someone else has another suggestion?
Contributor
Author
There was a problem hiding this comment.
PROCURE sounds good to me.
jleveque
suggested changes
Jul 2, 2018
rules/config
Outdated
|
|
||
| # DEFAULT_KERNEL_BUILD_METHOD - default method for building kernel | ||
| # build: build kernel from source | ||
| # download: downlaod built kernel from Azure storage. |
Contributor
There was a problem hiding this comment.
Also suggest changing "built" to "prebuilt".
jleveque
approved these changes
Jul 2, 2018
Contributor
jleveque
left a comment
jleveque
left a comment
There was a problem hiding this comment.
Please update title and description to reference new variable name.
yxieca
changed the title
5 tasks
qiluo-msft
pushed a commit
that referenced
this pull request
Sep 28, 2021
0d538d3 [ci]: Support code diff coverage (#1834) 48887d1 [config] support for configuring muxcable to standby mode of operation (#1837) 2088a9a Provide support to install platform extensions (#1578) c97fe54 Add check_db_integrity script to setup.py (#1828) c0b9917 [debug dump util] COPP Module Added (#1670) 826311c [techsupport] Removed interactive option for docker commands and Improved Error Reporting (#1723) ce11545 [config reload] Removed job-mode for sonic.target restart (#1820) f76f672 [fdbshow]: Fix typo in comment (#1809) 17208a0 [ci]: Support PR coverage (#1806) c2c2354 fix wrong code indent in sfputil (#1808) 47a9a0f [portconfig] Validate duplicate speed value and interface type value (#1745) f1086ee [sonic_installer]Add --skip-platform-check option for sonic_installer when image mismatch (#1791) c007d65 [warm-reboot] Add new preboot health check: verify database integrity (#1785) 41e31e8 Fix PatchApplier init order (#1762) 2416175 [config reload] Fix config reload failure due to sonic.target job cancellation (#1814) 2b12aad [portstat, intfstat] added rates and utilization (#1750) 26e700a [debug dump util] Techsupport addition (#1669) 9f2326e [debug dump util] Base Skeleton and Click Class added (#1668)
vdahiya12
added a commit
to vdahiya12/sonic-buildimage
that referenced
this pull request
Sep 29, 2021
0b5f90b (HEAD -> 202012, origin/202012) [show techsupport] fix bash errors in generate_dump script (sonic-net#1844) 388c50c [202012][warmboot] Add new preboot health check: verify db integrity (sonic-net#1839) d73dc98 [config] support for configuring muxcable to standby mode of operation (sonic-net#1837) Signed-off-by: vaibhav-dahiya <[email protected]>
5 tasks
lguohan
pushed a commit
that referenced
this pull request
Sep 30, 2021
0b5f90b (HEAD -> 202012, origin/202012) [show techsupport] fix bash errors in generate_dump script (#1844) 388c50c [202012][warmboot] Add new preboot health check: verify db integrity (#1839) d73dc98 [config] support for configuring muxcable to standby mode of operation (#1837) Signed-off-by: vaibhav-dahiya <[email protected]>
theasianpianist
pushed a commit
to theasianpianist/sonic-buildimage
that referenced
this pull request
Feb 5, 2022
…onic-net#2011) - What I did It's to port sonic-net#1837 to master to reclaim reserved buffer. As the way to do it differs among vendors, buffermgrd will: 1. Handle port admin down on Mellanox platform. - Not apply lossless buffer PG to an admin-down port - Remove lossless buffer PG (3-4) from a port when it is shut down. 2. Read lossless buffer PG (3-4) to a port when a port is started up. - Why I did it To support reclaiming reserved buffer when a port is shut down on Mellanox platform in traditional buffer model. - How I verified it sonic-mgmt test and vs test. Signed-off-by: Stephen Sun <[email protected]>
taras-keryk
pushed a commit
to taras-keryk/sonic-buildimage
that referenced
this pull request
Apr 28, 2022
sonic-net#1837) What I did This PR adds support for an option to configure muxcable mode to a standby mode. The standby mode is in addition to auto\active\manual mode. The new output would look like this in case an standby arg is passed to the command line admin@sonic:~$ sudo config muxcable mode standby Ethernet0 admin@sonic:~$ sudo config muxcable mode standby all added an option to set muxcable mode to standby mode, in addition to existing auto/active/manual modes. How I did it added the changes in config/muxcable.py and added testcases How to verify it Ran the unit tests Signed-off-by: vaibhav-dahiya <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: this PR is best go in before sonic-net/sonic-linux-kernel#51.
Signed-off-by: Ying Xie [email protected]
- What I did
Introducing the option of downloading pre-built kernel instead of building it every time.
- How to verify it