Rename SECURE_UPGRADE_DEV_SIGNING_CERT to SECURE_UPGRADE_SIGNING_CERT#315
Merged
saiarcot895 merged 2 commits intosonic-net:masterfrom Apr 19, 2023
Merged
Conversation
8 tasks
Collaborator
|
@davidpil2002 @saiarcot895 please review |
Contributor
|
Instead of “Change” please use “Rename” in the summaries. |
davidpil2002
approved these changes
Apr 13, 2023
DavidZagury
changed the title
qiluo-msft
approved these changes
Apr 18, 2023
saiarcot895
approved these changes
Apr 19, 2023
Collaborator
|
@saiarcot895 could you please add 202211 label? |
qiluo-msft
pushed a commit
to sonic-net/sonic-buildimage
that referenced
this pull request
Apr 24, 2023
…#14591) Depends on sonic-net/sonic-linux-kernel#315 #### Why I did it The name SECURE_UPGRADE_DEV_SIGNING_CERT is misleading, this flag is relevant to both to dev and prod signing. #### How I did it Rename all mentions of name SECURE_UPGRADE_DEV_SIGNING_CERT to SECURE_UPGRADE_SIGNING_CERT - this is also done with PR in sonic-linux-kernel repository #### How to verify it Build SONiC using your own prod script
DavidZagury
added a commit
to DavidZagury/sonic-linux-kernel
that referenced
this pull request
May 1, 2023
…sonic-net#315) Co-authored-by: Qi Luo <qiluo-msft@users.noreply.github.com>
DavidZagury
added a commit
to DavidZagury/sonic-buildimage
that referenced
this pull request
May 1, 2023
…sonic-net#14591) Depends on sonic-net/sonic-linux-kernel#315 #### Why I did it The name SECURE_UPGRADE_DEV_SIGNING_CERT is misleading, this flag is relevant to both to dev and prod signing. #### How I did it Rename all mentions of name SECURE_UPGRADE_DEV_SIGNING_CERT to SECURE_UPGRADE_SIGNING_CERT - this is also done with PR in sonic-linux-kernel repository #### How to verify it Build SONiC using your own prod script
vivekrnv
added a commit
to vivekrnv/sonic-linux-kernel
that referenced
this pull request
May 3, 2023
…sonic-net#315) Co-authored-by: Qi Luo <qiluo-msft@users.noreply.github.com>
DavidZagury
added a commit
to DavidZagury/sonic-buildimage
that referenced
this pull request
May 7, 2023
…E_SIGNING_CERT (sonic-net#14591) Depends on sonic-net/sonic-linux-kernel#315 The name SECURE_UPGRADE_DEV_SIGNING_CERT is misleading, this flag is relevant to both to dev and prod signing. Rename all mentions of name SECURE_UPGRADE_DEV_SIGNING_CERT to SECURE_UPGRADE_SIGNING_CERT - this is also done with PR in sonic-linux-kernel repository Build SONiC using your own prod script
StormLiangMS
pushed a commit
that referenced
this pull request
May 11, 2023
…#315) Co-authored-by: Qi Luo <qiluo-msft@users.noreply.github.com>
mssonicbld
pushed a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
May 15, 2023
…sonic-net#14591) Depends on sonic-net/sonic-linux-kernel#315 #### Why I did it The name SECURE_UPGRADE_DEV_SIGNING_CERT is misleading, this flag is relevant to both to dev and prod signing. #### How I did it Rename all mentions of name SECURE_UPGRADE_DEV_SIGNING_CERT to SECURE_UPGRADE_SIGNING_CERT - this is also done with PR in sonic-linux-kernel repository #### How to verify it Build SONiC using your own prod script
mssonicbld
pushed a commit
to sonic-net/sonic-buildimage
that referenced
this pull request
May 15, 2023
…#14591) Depends on sonic-net/sonic-linux-kernel#315 #### Why I did it The name SECURE_UPGRADE_DEV_SIGNING_CERT is misleading, this flag is relevant to both to dev and prod signing. #### How I did it Rename all mentions of name SECURE_UPGRADE_DEV_SIGNING_CERT to SECURE_UPGRADE_SIGNING_CERT - this is also done with PR in sonic-linux-kernel repository #### How to verify it Build SONiC using your own prod script
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The name SECURE_UPGRADE_DEV_SIGNING_CERT is misleading, this flag is relevant to both to dev and prod signing.
Rename all mentions of name SECURE_UPGRADE_DEV_SIGNING_CERT to SECURE_UPGRADE_SIGNING_CERT - this is also done with PR in sonic-buildimage repository - sonic-net/sonic-buildimage#14591