Rename SECURE_UPGRADE_DEV_SIGNING_CERT to SECURE_UPGRADE_SIGNING_CERT#14591
Merged
qiluo-msft merged 2 commits intosonic-net:masterfrom Apr 24, 2023
Merged
Rename SECURE_UPGRADE_DEV_SIGNING_CERT to SECURE_UPGRADE_SIGNING_CERT#14591qiluo-msft merged 2 commits intosonic-net:masterfrom
qiluo-msft merged 2 commits intosonic-net:masterfrom
Conversation
Collaborator
|
@davidpil2002 could you please help to review as well? |
davidpil2002
previously approved these changes
Apr 13, 2023
xumia
previously approved these changes
Apr 13, 2023
DavidZagury
changed the title
qiluo-msft
previously approved these changes
Apr 18, 2023
DavidZagury
dismissed stale reviews from qiluo-msft, xumia, and davidpil2002
via
e659441
DavidZagury
force-pushed
the
sign_remove_dev_from_flag
branch
from
e659441 to
d02e4d2
Compare
Contributor
Author
|
/azpw run Azure.sonic-buildimage |
Collaborator
|
/AzurePipelines run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
@qiluo-msft @xumia could you please help to review and merge? |
qiluo-msft
approved these changes
Apr 24, 2023
DavidZagury
added a commit
to DavidZagury/sonic-buildimage
that referenced
this pull request
May 1, 2023
…sonic-net#14591) Depends on sonic-net/sonic-linux-kernel#315 #### Why I did it The name SECURE_UPGRADE_DEV_SIGNING_CERT is misleading, this flag is relevant to both to dev and prod signing. #### How I did it Rename all mentions of name SECURE_UPGRADE_DEV_SIGNING_CERT to SECURE_UPGRADE_SIGNING_CERT - this is also done with PR in sonic-linux-kernel repository #### How to verify it Build SONiC using your own prod script
This was referenced May 1, 2023
10 tasks
DavidZagury
added a commit
to DavidZagury/sonic-buildimage
that referenced
this pull request
May 7, 2023
…E_SIGNING_CERT (sonic-net#14591) Depends on sonic-net/sonic-linux-kernel#315 The name SECURE_UPGRADE_DEV_SIGNING_CERT is misleading, this flag is relevant to both to dev and prod signing. Rename all mentions of name SECURE_UPGRADE_DEV_SIGNING_CERT to SECURE_UPGRADE_SIGNING_CERT - this is also done with PR in sonic-linux-kernel repository Build SONiC using your own prod script
mssonicbld
pushed a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
May 15, 2023
…sonic-net#14591) Depends on sonic-net/sonic-linux-kernel#315 #### Why I did it The name SECURE_UPGRADE_DEV_SIGNING_CERT is misleading, this flag is relevant to both to dev and prod signing. #### How I did it Rename all mentions of name SECURE_UPGRADE_DEV_SIGNING_CERT to SECURE_UPGRADE_SIGNING_CERT - this is also done with PR in sonic-linux-kernel repository #### How to verify it Build SONiC using your own prod script
Collaborator
|
Cherry-pick PR to 202211: #15066 |
mssonicbld
pushed a commit
that referenced
this pull request
May 15, 2023
…#14591) Depends on sonic-net/sonic-linux-kernel#315 #### Why I did it The name SECURE_UPGRADE_DEV_SIGNING_CERT is misleading, this flag is relevant to both to dev and prod signing. #### How I did it Rename all mentions of name SECURE_UPGRADE_DEV_SIGNING_CERT to SECURE_UPGRADE_SIGNING_CERT - this is also done with PR in sonic-linux-kernel repository #### How to verify it Build SONiC using your own prod script
mssonicbld
added
Included in 202211 Branch
and removed
Approved for 202211 Branch
Created PR to 202211 Branch
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on sonic-net/sonic-linux-kernel#315
Why I did it
The name SECURE_UPGRADE_DEV_SIGNING_CERT is misleading, this flag is relevant to both to dev and prod signing.
How I did it
Rename all mentions of name SECURE_UPGRADE_DEV_SIGNING_CERT to SECURE_UPGRADE_SIGNING_CERT - this is also done with PR in sonic-linux-kernel repository
How to verify it
Build SONiC using your own prod script
Which release branch to backport (provide reason below if selected)
Description for the changelog
Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU.
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)