[action] [PR:288] ICMP HW offload and ICMP_ECHO_SESSION support#297
Merged
mssonicbld merged 1 commit intosonic-net:202505from Jun 2, 2025
Merged
[action] [PR:288] ICMP HW offload and ICMP_ECHO_SESSION support#297mssonicbld merged 1 commit intosonic-net:202505from
mssonicbld merged 1 commit intosonic-net:202505from
Conversation
<!-- Please make sure you've read and understood our contributing guidelines; https://github.com/Azure/SONiC/blob/gh-pages/CONTRIBUTING.md Please provide following information to help code review process a bit easier: --> ### Description of PR - PR to support ICMP HW Offload feature . - For hardware probing we will use LinkProberHw. - Normal software probing is done by LinkProberSw. - New positive Probing timer added in Hardware Prober. - New handle recv logic added for both probers. Summary: Fixes # (issue) ### Type of change <!-- - Fill x for your type of change. - e.g. - [x] Bug fix --> - [ ] Bug fix - [ X] New feature - [ ] Doc/Design - [ ] Unit test ### Approach #### What is the motivation for this PR? Faster Probing and Switching in dualtor based system ##### Work item tracking - Microsoft ADO **(number only)**: #### How did you do it? SAI and SDK support for ICMP HW offload is implement and then linkmanagerd normaly handles ICMP_ECHO_SESSION and state of the device, links and session related to icmp_echo_session #### How did you verify/test it? In Progress #### Any platform specific information? ### Documentation <!-- (If it's a new feature, new test case) Did you update documentation/Wiki relevant to your implementation? Link to the wiki page? -->
Collaborator
Author
|
Original PR: #288 |
Collaborator
Author
|
/azp run |
3 tasks
|
Azure Pipelines successfully started running 1 pipeline(s). |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| MUXLOGDEBUG(mMuxPortConfig.getPortName()); | ||
|
|
||
| if (errorCode != boost::asio::error::operation_aborted) { | ||
| //ether_header *ethHeader = reinterpret_cast<ether_header *> (mRxBuffer.data()); |
Check notice
Code scanning / CodeQL
Commented-out code Note
| * GUID will indicate standby state. Lack of ICMP packets will signal | ||
| * that the link state is unknown and it might be newly learned peers UID | ||
| */ | ||
| class LinkProberBase |
Check warning
Code scanning / CodeQL
Non-virtual destructor in base class Warning
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
Type of change
Approach
What is the motivation for this PR?
Faster Probing and Switching in dualtor based system
Work item tracking
How did you do it?
SAI and SDK support for ICMP HW offload is implement and then linkmanagerd normaly handles ICMP_ECHO_SESSION
and state of the device, links and session related to icmp_echo_session
How did you verify/test it?
In Progress
Any platform specific information?
Documentation