ICMP HW offload and ICMP_ECHO_SESSION support#288
Merged
zjswhhh merged 14 commits intosonic-net:masterfrom May 30, 2025
Merged
Conversation
Signed-off-by: Harjot Singh <harjotpawrawork@gmail.com>
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Co-authored-by: manamand <manamand@cisco.com>
Co-authored-by: manamand <manamand@cisco.com>
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
harjotsinghpawra
force-pushed
the
harjosin_icmp
branch
from
b368083 to
23e4739
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
harjotsinghpawra
force-pushed
the
harjosin_icmp
branch
from
23e4739 to
d7c61f2
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
harjotsinghpawra
force-pushed
the
harjosin_icmp
branch
from
d7c61f2 to
b8e3713
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
harjotsinghpawra
force-pushed
the
harjosin_icmp
branch
from
b8e3713 to
726f522
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
harjotsinghpawra
force-pushed
the
harjosin_icmp
branch
from
726f522 to
ea79ec8
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Co-authored-by: manamand <manamand@cisco.com>
harjotsinghpawra
force-pushed
the
harjosin_icmp
branch
from
ea79ec8 to
f7703b8
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| MUXLOGDEBUG(mMuxPortConfig.getPortName()); | ||
|
|
||
| if (errorCode != boost::asio::error::operation_aborted) { | ||
| //ether_header *ethHeader = reinterpret_cast<ether_header *> (mRxBuffer.data()); |
Check notice
Code scanning / CodeQL
Commented-out code Note
| * GUID will indicate standby state. Lack of ICMP packets will signal | ||
| * that the link state is unknown and it might be newly learned peers UID | ||
| */ | ||
| class LinkProberBase |
Check warning
Code scanning / CodeQL
Non-virtual destructor in base class Warning
Signed-off-by: Manas Kumar Mandal <manamand@cisco.com>
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
zjswhhh
previously approved these changes
May 25, 2025
Collaborator
|
Hi @prsunny - the missing coverage is mainly existing code (i.e. we moved software link prober solution to |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
Cherry-pick PR to 202505: #297 |
yejianquan
added
Included in 202505 Branch
and removed
Created PR to 202505 Branch
labels
This was referenced Jun 19, 2025
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
Type of change
Approach
What is the motivation for this PR?
Faster Probing and Switching in dualtor based system
Work item tracking
How did you do it?
SAI and SDK support for ICMP HW offload is implement and then linkmanagerd normaly handles ICMP_ECHO_SESSION
and state of the device, links and session related to icmp_echo_session
How did you verify/test it?
In Progress
Any platform specific information?
Documentation