[active-standby] add knob to enable/disable oscillation #250
Merged
lolyu merged 6 commits intosonic-net:masterfrom May 25, 2024
Merged
[active-standby] add knob to enable/disable oscillation #250lolyu merged 6 commits intosonic-net:masterfrom
lolyu merged 6 commits intosonic-net:masterfrom
Conversation
lolyu
approved these changes
May 25, 2024
8 tasks
Contributor
|
Hi @yxieca, could you please cherry-pick this into 202311 branch? |
mssonicbld
pushed a commit
to mssonicbld/sonic-linkmgrd
that referenced
this pull request
Jun 5, 2024
### Approach #### What is the motivation for this PR? To avoid test flakiness. ##### Work item tracking - Microsoft ADO **(number only)**: - 28187403 #### How did you do it? 1. Add DB interface to enable/disable the oscillation feature 2. Add DB interface to config the oscillation interval #### How did you verify/test it? Tested on lab device: 1. Knob was default on 2. Turned it off 3. Turned it on 4. Changed the interval #### Any platform specific information?
Collaborator
|
Cherry-pick PR to 202311: #252 |
mssonicbld
pushed a commit
that referenced
this pull request
Jun 5, 2024
### Approach #### What is the motivation for this PR? To avoid test flakiness. ##### Work item tracking - Microsoft ADO **(number only)**: - 28187403 #### How did you do it? 1. Add DB interface to enable/disable the oscillation feature 2. Add DB interface to config the oscillation interval #### How did you verify/test it? Tested on lab device: 1. Knob was default on 2. Turned it off 3. Turned it on 4. Changed the interval #### Any platform specific information?
mssonicbld
added
Included in 202311 Branch
and removed
Created PR to 202311 Branch
labels
11 tasks
StormLiangMS
pushed a commit
to sonic-net/sonic-buildimage
that referenced
this pull request
Jun 13, 2024
Why I did it A new flag was introduced in sonic-net/sonic-linkmgrd#250 to disable mux oscillations but yang model wasn't updated. We are seeing multiple tests failing due to this, some of them are - generic_config_updater/test_dynamic_acl.py passw_hardening/test_passw_hardening.py dualtor_mgmt/test_toggle_mux.py
mssonicbld
pushed a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
Jun 13, 2024
Why I did it A new flag was introduced in sonic-net/sonic-linkmgrd#250 to disable mux oscillations but yang model wasn't updated. We are seeing multiple tests failing due to this, some of them are - generic_config_updater/test_dynamic_acl.py passw_hardening/test_passw_hardening.py dualtor_mgmt/test_toggle_mux.py
mssonicbld
pushed a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
Jun 14, 2024
Why I did it A new flag was introduced in sonic-net/sonic-linkmgrd#250 to disable mux oscillations but yang model wasn't updated. We are seeing multiple tests failing due to this, some of them are - generic_config_updater/test_dynamic_acl.py passw_hardening/test_passw_hardening.py dualtor_mgmt/test_toggle_mux.py
mssonicbld
pushed a commit
to sonic-net/sonic-buildimage
that referenced
this pull request
Jun 15, 2024
Why I did it A new flag was introduced in sonic-net/sonic-linkmgrd#250 to disable mux oscillations but yang model wasn't updated. We are seeing multiple tests failing due to this, some of them are - generic_config_updater/test_dynamic_acl.py passw_hardening/test_passw_hardening.py dualtor_mgmt/test_toggle_mux.py
mssonicbld
pushed a commit
to sonic-net/sonic-buildimage
that referenced
this pull request
Jun 15, 2024
Why I did it A new flag was introduced in sonic-net/sonic-linkmgrd#250 to disable mux oscillations but yang model wasn't updated. We are seeing multiple tests failing due to this, some of them are - generic_config_updater/test_dynamic_acl.py passw_hardening/test_passw_hardening.py dualtor_mgmt/test_toggle_mux.py
henrymao-zz
pushed a commit
to canonical/sonic-buildimage
that referenced
this pull request
Jun 23, 2024
Why I did it A new flag was introduced in sonic-net/sonic-linkmgrd#250 to disable mux oscillations but yang model wasn't updated. We are seeing multiple tests failing due to this, some of them are - generic_config_updater/test_dynamic_acl.py passw_hardening/test_passw_hardening.py dualtor_mgmt/test_toggle_mux.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
Add knob to enable/disable oscillation.
sign-off: Jing Zhang zhangjing@microsoft.com
Type of change
Approach
What is the motivation for this PR?
To avoid test flakiness.
Work item tracking
How did you do it?
How did you verify/test it?
Tested on lab device:
Any platform specific information?
Documentation