Skip to content

Update sonic-mux-linkmgr yang model#19275

Merged
StormLiangMS merged 2 commits intosonic-net:masterfrom
vivekverma-arista:linkmgrd-yang-model
Jun 13, 2024
Merged

Update sonic-mux-linkmgr yang model#19275
StormLiangMS merged 2 commits intosonic-net:masterfrom
vivekverma-arista:linkmgrd-yang-model

Conversation

@vivekverma-arista
Copy link
Copy Markdown
Contributor

@vivekverma-arista vivekverma-arista commented Jun 11, 2024

Why I did it

A new flag was introduced in sonic-net/sonic-linkmgrd#250 to disable mux oscillations but yang model wasn't updated. We are seeing multiple tests failing due to this, some of them are -

  1. generic_config_updater/test_dynamic_acl.py
  2. passw_hardening/test_passw_hardening.py
  3. dualtor_mgmt/test_toggle_mux.py
Work item tracking

How I did it

How to verify it

Ran the failing tests with the image.

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211
  • 202311

Tested branch (Please provide the tested image version)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

Copy link
Copy Markdown
Contributor

@lolyu lolyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please check the PR test failures?

@vivekverma-arista
Copy link
Copy Markdown
Contributor Author

Details

##[error]We stopped hearing from agent sonic-ubu000AQ9. Verify the agent machine is running and has a healthy network connection. Anything that terminates an agent process, starves it for CPU, or blocks its network access can cause this error.

Looks like infra thing. @lolyu can you fire the run again.

Copy link
Copy Markdown
Contributor

@lolyu lolyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor

@StormLiangMS StormLiangMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@StormLiangMS
Copy link
Copy Markdown
Contributor

@bingwang-ms for 202405 cherry pick.

@vivekverma-arista vivekverma-arista deleted the linkmgrd-yang-model branch June 13, 2024 06:30
mssonicbld pushed a commit to mssonicbld/sonic-buildimage that referenced this pull request Jun 13, 2024
Why I did it
A new flag was introduced in sonic-net/sonic-linkmgrd#250 to disable mux oscillations but yang model wasn't updated. We are seeing multiple tests failing due to this, some of them are -

generic_config_updater/test_dynamic_acl.py
passw_hardening/test_passw_hardening.py
dualtor_mgmt/test_toggle_mux.py
@mssonicbld
Copy link
Copy Markdown
Collaborator

Cherry-pick PR to 202311: #19299

@bingwang-ms
Copy link
Copy Markdown
Contributor

@bingwang-ms for 202405 cherry pick.

Done.

mssonicbld pushed a commit to mssonicbld/sonic-buildimage that referenced this pull request Jun 14, 2024
Why I did it
A new flag was introduced in sonic-net/sonic-linkmgrd#250 to disable mux oscillations but yang model wasn't updated. We are seeing multiple tests failing due to this, some of them are -

generic_config_updater/test_dynamic_acl.py
passw_hardening/test_passw_hardening.py
dualtor_mgmt/test_toggle_mux.py
@mssonicbld
Copy link
Copy Markdown
Collaborator

Cherry-pick PR to 202405: #19308

mssonicbld pushed a commit that referenced this pull request Jun 15, 2024
Why I did it
A new flag was introduced in sonic-net/sonic-linkmgrd#250 to disable mux oscillations but yang model wasn't updated. We are seeing multiple tests failing due to this, some of them are -

generic_config_updater/test_dynamic_acl.py
passw_hardening/test_passw_hardening.py
dualtor_mgmt/test_toggle_mux.py
mssonicbld pushed a commit that referenced this pull request Jun 15, 2024
Why I did it
A new flag was introduced in sonic-net/sonic-linkmgrd#250 to disable mux oscillations but yang model wasn't updated. We are seeing multiple tests failing due to this, some of them are -

generic_config_updater/test_dynamic_acl.py
passw_hardening/test_passw_hardening.py
dualtor_mgmt/test_toggle_mux.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants