Skip to content

Add ExclusionList for telemetry/frr_bmp since they are not service in pub repo#317

Merged
FengPan-Frank merged 3 commits intosonic-net:masterfrom
FengPan-Frank:fix_featured
Nov 12, 2025
Merged

Add ExclusionList for telemetry/frr_bmp since they are not service in pub repo#317
FengPan-Frank merged 3 commits intosonic-net:masterfrom
FengPan-Frank:fix_featured

Conversation

@FengPan-Frank
Copy link
Contributor

Add whitelist for telemetry/frr_bmp since they are not service in pub repo

@mssonicbld
Copy link

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

scripts/featured Outdated
FEATURE_STATE_ENABLED = "enabled"
FEATURE_STATE_DISABLED = "disabled"
FEATURE_STATE_FAILED = "failed"
FEATURE_WHITELIST = {"telemetry", "frr_bmp"}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: shouldn't this be blacklist instead?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or FEATURE_EXCLUSION_LIST

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed.

@FengPan-Frank FengPan-Frank changed the title Add whitelist for telemetry/frr_bmp since they are not service in pub repo Add ExclusionList for telemetry/frr_bmp since they are not service in pub repo Nov 12, 2025
@FengPan-Frank
Copy link
Contributor Author

/azpw run

@mssonicbld
Copy link

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@FengPan-Frank FengPan-Frank merged commit f1de8e3 into sonic-net:master Nov 12, 2025
5 checks passed
@mssonicbld
Copy link

Cherry-pick PR to 202511: #328

zbud-msft added a commit to zbud-msft/sonic-host-services that referenced this pull request Jan 13, 2026
@pavannaregundi
Copy link

@FengPan-Frank In 202511, when attempting to start the telemetry Docker with the command:
config feature start telemetry enabled
the telemetry feature is excluded due to changes introduced in this PR.

Questions

  • How can someone who built the image with INCLUDE_SYSTEM_TELEMETRY=y enable the telemetry feature?
  • Runtime Exclusion: Is there a way to remove the feature from the exclude list at runtime?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants