[featured] fix non existing feature start#314
Merged
lihuay merged 1 commit intosonic-net:masterfrom Feb 25, 2026
Merged
Conversation
Fix an issue that when starting a non existing feature and then installing it with sonic-package-manager it won't start. E.g: admin@sonic:~$ redis-cli -n 4 hmset 'FEATURE|non-existing' state enabled OK admin@sonic:~$ sudo zless /var/log/syslog | grep featured 2025 Mar 26 15:19:33.237090 sonic INFO featured: Feature non-existing is enabled and started With this patch an error is recorded and feature state is not cached: 2025 Mar 26 15:35:32.794640 sonic INFO featured: Running cmd: '['sudo', 'systemctl', 'unmask', 'non-existing.service']' 2025 Mar 26 15:35:33.233685 sonic INFO featured: Output: , Stderr: Unit non-existing.service does not exist, proceeding anyway. 2025 Mar 26 15:35:33.233743 sonic INFO featured: Running cmd: '['sudo', 'systemctl', 'enable', 'non-existing.service']' 2025 Mar 26 15:35:33.247238 sonic ERR featured: ['sudo', 'systemctl', 'enable', 'non-existing.service'] - failed: return code - 1, output: 2025 Mar 26 15:35:33.247300 sonic ERR featured: Feature 'non-existing.service' failed to be enabled and started 2025 Mar 26 15:35:39.331762 sonic INFO featured: Running cmd: '['sudo', 'systemctl', 'unmask', 'non-existing.service']' 2025 Mar 26 15:35:39.780474 sonic INFO featured: Output: , Stderr: Unit non-existing.service does not exist, proceeding anyway. 2025 Mar 26 15:35:39.780513 sonic INFO featured: Running cmd: '['sudo', 'systemctl', 'enable', 'non-existing.service']' 2025 Mar 26 15:35:39.795113 sonic ERR featured: ['sudo', 'systemctl', 'enable', 'non-existing.service'] - failed: return code - 1, output: 2025 Mar 26 15:35:39.795153 sonic ERR featured: Feature 'non-existing.service' failed to be enabled and started Feature will start next time when setting state field in FEATURE table Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
Depends on #317 |
Contributor
Author
|
/azpw run |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
liat-grozovik
approved these changes
Feb 2, 2026
Collaborator
liat-grozovik
left a comment
liat-grozovik
left a comment
There was a problem hiding this comment.
LGTM. Pending others to review and confirm
qiluo-msft
reviewed
Feb 2, 2026
| if enable: | ||
| self.enable_feature(feature) | ||
| if not self.enable_feature(feature): | ||
| return False |
Contributor
|
Cherry-pick PR to 202511: #354 |
mssonicbld
added
Included in 202511 Branch
and removed
Created PR to 202511 Branch
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix an issue that when starting a non existing feature and then installing it with sonic-package-manager it won't start.
E.g:
With this patch an error is recordded and feature state is not cached:
Feature will start next time when setting state field in FEATURE table