[kdump-config] update kdump default config with pre-defined value in /proc/cmdline (installer.conf) (cherry-pick from master to 202405)#236
Merged
judyjoseph merged 2 commits intosonic-net:202405from May 7, 2025
Conversation
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
@judyjoseph and @arlakshm This PRs the set the Kdump config enabled and memory value which based on the pre-defined crashkernel in /proc/cmdline. Please review it. Thanks |
12 tasks
mlok-nokia
changed the title
Contributor
|
@mlok-nokia, as discussed can we create PR in master branch for this change? |
Contributor
Author
I am working on that..... |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
mlok-nokia
changed the title
10 tasks
mlok-nokia
force-pushed
the
update-kdump-config
branch
from
906a7a5 to
0180251
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
mlok-nokia
force-pushed
the
update-kdump-config
branch
from
0180251 to
6b386db
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
…efined in a platform installer.conf Signed-off-by: mlok <marty.lok@nokia.com> (cherry picked from commit bc75b4e5a40e40e49f4352c810b28dedd385d16b)
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
@judyjoseph and @arlakshm This is the cherry-pick of PR of the kdump-config. Please review it. Thanks. |
Contributor
Author
|
@judyjoseph This PR also needs to cherry-pick to 202503 branch |
Contributor
Author
|
@judyjoseph @arlakshm Please cherry-pick this PR to 202503 branch. Thanks. |
Contributor
Author
|
@tjchadaga, @judyjoseph and @arlakshm This PR has not been cherry-picked to MSFT 202503 branch yet. Thanks |
mssonicbld
added a commit
to mssonicbld/sonic-host-services
that referenced
this pull request
Oct 24, 2025
…/proc/cmdline (installer.conf) #### Why I did it Modify the hostcfgd to handle the kdump enabled to the CONFIG_DB when kdump is enabled by default in the platform installer.conf . Related PR for 202405 is: sonic-net#236 ### How I did it Added a new method init_kdump_config_from_cmdline() in the KdumpCfg class to check the /proc/cmdline. If key "crashkernel=" exists in /proc/cmdline when system is up, this means that the kdump is enabled. init_kdump_config_from_cmdline() will update the kdump_defaults and CONFIG_DB when if the current config data are not matched the pre-defined data in the /proc/cmdline. This happens during a new image upgrade with the crashkernel is defined the platform installer.conf. ### How to verify it 1) install an image with predefine kdump enabled in the grub.conf. 2) execute the "config load_minigraph" - check it should not any error in the syslog - After the hostcfgd is running, execute "show kdump config" should show kdump is enabled. Output as below ``` admin@sonic:~$ show kdump config Kdump administrative mode: Enabled Kdump operational mode: Ready Kdump memory reservation: 8G-:1G Maximum number of Kdump files: 3 ``` 3) save config and reboot the system 4) show command should show the kdump is enabled and also there should not be any kdump/hostcfgd error log in syslog ### Which release branch to backport (provide reason below if selected) - [ ] 201811 - [ ] 201911 - [ ] 202006 - [ ] 202012 - [ ] 202106 - [ ] 202111 - [ ] 202205 - [ ] 202211 - [ ] 202305 - [x] 202405
10 tasks
mssonicbld
added a commit
that referenced
this pull request
Oct 27, 2025
…-defined value in /proc/cmdline (installer.conf) (#315) #### Why I did it Modify the hostcfgd to handle the kdump enabled to the CONFIG_DB when kdump is enabled by default in the platform installer.conf . Related PR for 202405 is: #236 ### How I did it Added a new method init_kdump_config_from_cmdline() in the KdumpCfg class to check the /proc/cmdline. If key "crashkernel=" exists in /proc/cmdline when system is up, this means that the kdump is enabled. init_kdump_config_from_cmdline() will update the kdump_defaults and CONFIG_DB when if the current config data are not matched the pre-defined data in the /proc/cmdline. This happens during a new image upgrade with the crashkernel is defined the platform installer.conf. ### How to verify it 1) install an image with predefine kdump enabled in the grub.conf. 2) execute the "config load_minigraph" - check it should not any error in the syslog - After the hostcfgd is running, execute "show kdump config" should show kdump is enabled. Output as below ``` admin@sonic:~$ show kdump config Kdump administrative mode: Enabled Kdump operational mode: Ready Kdump memory reservation: 8G-:1G Maximum number of Kdump files: 3 ``` 3) save config and reboot the system 4) show command should show the kdump is enabled and also there should not be any kdump/hostcfgd error log in syslog ### Which release branch to backport (provide reason below if selected) - [ ] 201811 - [ ] 201911 - [ ] 202006 - [ ] 202012 - [ ] 202106 - [ ] 202111 - [ ] 202205 - [ ] 202211 - [ ] 202305 - [x] 202405
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
Modify the hostcfgd to handle the kdump enabled to the CONFIG_DB when kdump is enabled by default in the platform installer.conf. Related PR in master branch is #237
How I did it
Added a new method init_kdump_config_from_cmdline() in the KdumpCfg class to check the /proc/cmdline. If key "crashkernel=" exists in /proc/cmdline when system is up, this means that the kdump is enabled. init_kdump_config_from_cmdline() will update the kdump_defaults and CONFIG_DB when if the current config data are not matched the pre-defined data in the /proc/cmdline. This happens during a new image upgrade with the crashkernel is defined the platform installer.conf.
How to verify it
Which release branch to backport (provide reason below if selected)