Skip to content

[Nokia 7250e] enable crashkernel#22034

Merged
rlhui merged 2 commits intosonic-net:masterfrom
jon-nokia:dev-jon
Apr 11, 2025
Merged

[Nokia 7250e] enable crashkernel#22034
rlhui merged 2 commits intosonic-net:masterfrom
jon-nokia:dev-jon

Conversation

@jon-nokia
Copy link
Contributor

@jon-nokia jon-nokia commented Mar 13, 2025

Why I did it

Enable support to gather vmcore in the event of kernel panic.

Work item tracking
  • Microsoft ADO (number only):

How I did it

How to verify it

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211
  • 202305
  • 202405

Can be cherry-picked to 202405.

Tested branch (Please provide the tested image version)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

@jon-nokia jon-nokia marked this pull request as ready for review March 13, 2025 20:23
@jon-nokia
Copy link
Contributor Author

@judyjoseph please review for inclusion to 202405

judyjoseph
judyjoseph previously approved these changes Mar 18, 2025
@judyjoseph
Copy link
Contributor

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@judyjoseph judyjoseph self-requested a review March 22, 2025 00:11
@mlok-nokia
Copy link
Contributor

mlok-nokia commented Apr 4, 2025

This PR is also related PR sonic-net/sonic-host-services#236 which sets the kdump_defaults config with predefined value in /proc/cmdline

@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@judyjoseph
Copy link
Contributor

@jon-nokia for aer , this will go with NDK : Azure/sonic-buildimage-msft#738 ? and pmon : Azure/sonic-buildimage-msft#719 ?

Copy link
Contributor

@judyjoseph judyjoseph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jon-nokia
Copy link
Contributor Author

@jon-nokia for aer , this will go with NDK : Azure/sonic-buildimage-msft#738 ? and pmon : Azure/sonic-buildimage-msft#719 ?

Yes, the aer change is in this PR and depends upon having previously merged 738 and 719 as you indicated above.

@rlhui rlhui merged commit 85c1773 into sonic-net:master Apr 11, 2025
19 checks passed
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to msft-202405: Azure/sonic-buildimage-msft#981

arlakshm pushed a commit to sonic-net/sonic-mgmt that referenced this pull request May 19, 2025
…th sup instead of cold reboot (#18393)

What is the motivation for this PR?
Changed in 7250e code makes kernel panic on sup cards leave reboot-cause on LCs as Heartbeat with supervisor card lost instead of cold

sonic-net/sonic-buildimage#22034

How did you do it?
Add Nokia-IXR7250E to SKUs checking for Heartbeat lost cause rather than cold cause in test_kdump.py

Signed-off-by: Javier Tan [email protected]
mssonicbld added a commit to mssonicbld/sonic-mgmt.msft that referenced this pull request May 19, 2025
…rnel panics

<!--
Please make sure you've read and understood our contributing guidelines;
https://github.com/sonic-net/SONiC/blob/gh-pages/CONTRIBUTING.md

Please provide following information to help code review process a bit easier:
-->
### Description of PR
<!--
- Please include a summary of the change and which issue is fixed.
- Please also include relevant motivation and context. Where should reviewer start? background context?
- List any dependencies that are required for this change.
-->

Summary:
Fixes #18392

### Type of change

<!--
- Fill x for your type of change.
- e.g.
- [x] Bug fix
-->

- [x] Bug fix
- [ ] Testbed and Framework(new/improvement)
- [ ] New Test case
    - [ ] Skipped for non-supported platforms
- [ ] Test case improvement

### Back port request
- [ ] 202012
- [ ] 202205
- [ ] 202305
- [ ] 202311
- [x] 202405
- [ ] 202411

### Approach
#### What is the motivation for this PR?
Changed in 7250e code makes kernel panic on sup cards leave reboot-cause on LCs as `Heartbeat with supervisor card lost` instead of `cold`

sonic-net/sonic-buildimage#22034
#### How did you do it?
Add `Nokia-IXR7250E` to SKUs checking for `Heartbeat lost` cause rather than `cold` cause in `test_kdump.py`
#### How did you verify/test it?
TBC
#### Any platform specific information?
7250E
#### Supported testbed topology if it's a new test case?
N/A
### Documentation
<!--
(If it's a new feature, new test case)
Did you update documentation/Wiki relevant to your implementation?
Link to the wiki page?
-->
N/A
mssonicbld added a commit to mssonicbld/sonic-mgmt.msft that referenced this pull request May 19, 2025
…rnel panics

<!--
Please make sure you've read and understood our contributing guidelines;
https://github.com/sonic-net/SONiC/blob/gh-pages/CONTRIBUTING.md

Please provide following information to help code review process a bit easier:
-->
### Description of PR
<!--
- Please include a summary of the change and which issue is fixed.
- Please also include relevant motivation and context. Where should reviewer start? background context?
- List any dependencies that are required for this change.
-->

Summary:
Fixes #18392

### Type of change

<!--
- Fill x for your type of change.
- e.g.
- [x] Bug fix
-->

- [x] Bug fix
- [ ] Testbed and Framework(new/improvement)
- [ ] New Test case
    - [ ] Skipped for non-supported platforms
- [ ] Test case improvement

### Back port request
- [ ] 202012
- [ ] 202205
- [ ] 202305
- [ ] 202311
- [x] 202405
- [ ] 202411

### Approach
#### What is the motivation for this PR?
Changed in 7250e code makes kernel panic on sup cards leave reboot-cause on LCs as `Heartbeat with supervisor card lost` instead of `cold`

sonic-net/sonic-buildimage#22034
#### How did you do it?
Add `Nokia-IXR7250E` to SKUs checking for `Heartbeat lost` cause rather than `cold` cause in `test_kdump.py`
#### How did you verify/test it?
TBC
#### Any platform specific information?
7250E
#### Supported testbed topology if it's a new test case?
N/A
### Documentation
<!--
(If it's a new feature, new test case)
Did you update documentation/Wiki relevant to your implementation?
Link to the wiki page?
-->
N/A
mssonicbld added a commit to Azure/sonic-mgmt.msft that referenced this pull request May 19, 2025
…with sup when Sup kernel panics (#298)

<!--
Please make sure you've read and understood our contributing guidelines;
https://github.com/sonic-net/SONiC/blob/gh-pages/CONTRIBUTING.md

Please provide following information to help code review process a bit easier:
-->
### Description of PR
<!--
- Please include a summary of the change and which issue is fixed.
- Please also include relevant motivation and context. Where should reviewer start? background context?
- List any dependencies that are required for this change.
-->

Summary:
Fixes #18392

### Type of change

<!--
- Fill x for your type of change.
- e.g.
- [x] Bug fix
-->

- [x] Bug fix
- [ ] Testbed and Framework(new/improvement)
- [ ] New Test case
 - [ ] Skipped for non-supported platforms
- [ ] Test case improvement

### Back port request
- [ ] 202012
- [ ] 202205
- [ ] 202305
- [ ] 202311
- [x] 202405
- [ ] 202411

### Approach
#### What is the motivation for this PR?
Changed in 7250e code makes kernel panic on sup cards leave reboot-cause on LCs as `Heartbeat with supervisor card lost` instead of `cold`

sonic-net/sonic-buildimage#22034
#### How did you do it?
Add `Nokia-IXR7250E` to SKUs checking for `Heartbeat lost` cause rather than `cold` cause in `test_kdump.py`
#### How did you verify/test it?
TBC
#### Any platform specific information?
7250E
#### Supported testbed topology if it's a new test case?
N/A
### Documentation
<!--
(If it's a new feature, new test case)
Did you update documentation/Wiki relevant to your implementation?
Link to the wiki page?
-->
N/A
mssonicbld added a commit to Azure/sonic-mgmt.msft that referenced this pull request May 19, 2025
…with sup when Sup kernel panics (#297)

<!--
Please make sure you've read and understood our contributing guidelines;
https://github.com/sonic-net/SONiC/blob/gh-pages/CONTRIBUTING.md

Please provide following information to help code review process a bit easier:
-->
### Description of PR
<!--
- Please include a summary of the change and which issue is fixed.
- Please also include relevant motivation and context. Where should reviewer start? background context?
- List any dependencies that are required for this change.
-->

Summary:
Fixes #18392

### Type of change

<!--
- Fill x for your type of change.
- e.g.
- [x] Bug fix
-->

- [x] Bug fix
- [ ] Testbed and Framework(new/improvement)
- [ ] New Test case
 - [ ] Skipped for non-supported platforms
- [ ] Test case improvement

### Back port request
- [ ] 202012
- [ ] 202205
- [ ] 202305
- [ ] 202311
- [x] 202405
- [ ] 202411

### Approach
#### What is the motivation for this PR?
Changed in 7250e code makes kernel panic on sup cards leave reboot-cause on LCs as `Heartbeat with supervisor card lost` instead of `cold`

sonic-net/sonic-buildimage#22034
#### How did you do it?
Add `Nokia-IXR7250E` to SKUs checking for `Heartbeat lost` cause rather than `cold` cause in `test_kdump.py`
#### How did you verify/test it?
TBC
#### Any platform specific information?
7250E
#### Supported testbed topology if it's a new test case?
N/A
### Documentation
<!--
(If it's a new feature, new test case)
Did you update documentation/Wiki relevant to your implementation?
Link to the wiki page?
-->
N/A
opcoder0 pushed a commit to opcoder0/sonic-mgmt that referenced this pull request Dec 8, 2025
…th sup instead of cold reboot (sonic-net#18393)

What is the motivation for this PR?
Changed in 7250e code makes kernel panic on sup cards leave reboot-cause on LCs as Heartbeat with supervisor card lost instead of cold

sonic-net/sonic-buildimage#22034

How did you do it?
Add Nokia-IXR7250E to SKUs checking for Heartbeat lost cause rather than cold cause in test_kdump.py

Signed-off-by: Javier Tan [email protected]
AharonMalkin pushed a commit to AharonMalkin/sonic-mgmt that referenced this pull request Dec 16, 2025
…th sup instead of cold reboot (sonic-net#18393)

What is the motivation for this PR?
Changed in 7250e code makes kernel panic on sup cards leave reboot-cause on LCs as Heartbeat with supervisor card lost instead of cold

sonic-net/sonic-buildimage#22034

How did you do it?
Add Nokia-IXR7250E to SKUs checking for Heartbeat lost cause rather than cold cause in test_kdump.py

Signed-off-by: Javier Tan [email protected]
Signed-off-by: Aharon Malkin <[email protected]>
gshemesh2 pushed a commit to gshemesh2/sonic-mgmt that referenced this pull request Dec 21, 2025
…th sup instead of cold reboot (sonic-net#18393)

What is the motivation for this PR?
Changed in 7250e code makes kernel panic on sup cards leave reboot-cause on LCs as Heartbeat with supervisor card lost instead of cold

sonic-net/sonic-buildimage#22034

How did you do it?
Add Nokia-IXR7250E to SKUs checking for Heartbeat lost cause rather than cold cause in test_kdump.py

Signed-off-by: Javier Tan [email protected]
Signed-off-by: Guy Shemesh <[email protected]>
gshemesh2 pushed a commit to gshemesh2/sonic-mgmt that referenced this pull request Jan 26, 2026
…th sup instead of cold reboot (sonic-net#18393)

What is the motivation for this PR?
Changed in 7250e code makes kernel panic on sup cards leave reboot-cause on LCs as Heartbeat with supervisor card lost instead of cold

sonic-net/sonic-buildimage#22034

How did you do it?
Add Nokia-IXR7250E to SKUs checking for Heartbeat lost cause rather than cold cause in test_kdump.py

Signed-off-by: Javier Tan [email protected]
Signed-off-by: Guy Shemesh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants