Merged
Conversation
6 tasks
saiarcot895
reviewed
Aug 3, 2022
Contributor
|
Is there unit test to cover this change? |
saiarcot895
approved these changes
Aug 9, 2022
Collaborator
saiarcot895
left a comment
saiarcot895
left a comment
There was a problem hiding this comment.
Approved pending unit tests.
Collaborator
Collaborator
Author
Contributor
yxieca
approved these changes
Sep 1, 2022
kellyyeh
added a commit
to kellyyeh/sonic-dhcp-relay
that referenced
this pull request
Oct 8, 2022
* Add interface-id option * Add out of bound check
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
Support interface-id option with opaque value carrying link-address which will be used in dual-tor
How I did it
Add interface-id option in DHCP_RELAY configuration table, copy link-address to interface-id value