[dhcp6relay] Add interface-id option#10571
Closed
kellyyeh wants to merge 1 commit intosonic-net:masterfrom
Closed
Conversation
Contributor
|
Add unit test? |
yxieca
reviewed
Apr 13, 2022
| } | ||
| if(f == "dhcpv6_option|interface_id" && v == "true") { // interface-id is off by default on non-Dual-ToR, unless specified in config db | ||
| intf.is_interface_id = true; | ||
| } |
Contributor
There was a problem hiding this comment.
What if config_db changed from true to false? You only allow one direction change?
Same question for 136-138.
Contributor
Author
There was a problem hiding this comment.
option79 is true and interface_id is false by default(line 120-121) if not specified in config_db
changes in config_db will require dhcp6relay restart to take effect
Contributor
Author
Noted |
Contributor
|
@kellyyeh please move this PR to the submodule. |
Contributor
Author
|
Cherry-pick to sonic-dhcp-relay submodule by PR sonic-net/sonic-dhcp-relay#8 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
Support interface-id option with opaque value carrying link-address which will be used in dual-tor
How I did it
Add interface-id option in DHCP_RELAY configuration table, copy link-address to interface-id value
How to verify it
Which release branch to backport (provide reason below if selected)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)